homebrew and llvm 10 packages in apt.llvm.org are broken with undefined reference to getPollyPluginInfo

[heidezomp]

Building with the shiny new llvm10 fails:

[ 98%] Linking CXX executable zig0
/usr/lib/llvm-10/lib/libclangCodeGen.a(BackendUtil.cpp.o): In function `(anonymous namespace)::EmitAssemblyHelper::EmitAssemblyWithNewPassManager(clang::BackendAction, std::unique_ptr<llvm::raw_pwrite_stream, std::default_delete<llvm::raw_pwrite_stream> >)':
BackendUtil.cpp:(.text._ZN12_GLOBAL__N_118EmitAssemblyHelper30EmitAssemblyWithNewPassManagerEN5clang13BackendActionESt10unique_ptrIN4llvm17raw_pwrite_streamESt14default_deleteIS5_EE+0x16df): undefined reference to `getPollyPluginInfo()'
collect2: error: ld returned 1 exit status
CMakeFiles/zig0.dir/build.make:163: recipe for target 'zig0' failed

I have installed llvm10 from the official apt repository:

deb http://apt.llvm.org/bionic/ llvm-toolchain-bionic-10 main

Might this be a problem with my installation?

[andrewrk]

It's a problem with apt.llvm.org. They're aware and will hopefully fix it soon. In the meantime, you'll have to use the same workaround that the CI uses, or build llvm+clang+lld 10 from source.

---

homebrew workaround

[andrewrk]

Direct link to upstream bug report

[yrashk]

I am having the same issue with an attempt to combine this LLVM 10 (release) PR in Nixpkgs NixOS/nixpkgs#83350 and the following change to zig's derivation:

diff --git a/pkgs/development/compilers/zig/default.nix b/pkgs/development/compilers/zig/default.nix
index 961e28da82e..ab43c862227 100644
--- a/pkgs/development/compilers/zig/default.nix
+++ b/pkgs/development/compilers/zig/default.nix
@@ -1,18 +1,18 @@
 { stdenv, fetchFromGitHub, cmake, llvmPackages, libxml2, zlib }:
 
 stdenv.mkDerivation rec {
-  version = "0.5.0";
+  version = "0d43543";
   pname = "zig";
 
   src = fetchFromGitHub {
     owner = "ziglang";
     repo = pname;
     rev = version;
-    sha256 = "0xyl0riakh6kwb3yvxihb451kqs4ai4q0aygqygnlb2rlr1dn1zb";
+    sha256 = "144igsf104dlwf8rvxg0dk6brlv73ywhq35r5nnljra81h52wzf9";
   };
 
   nativeBuildInputs = [ cmake ];
-  buildInputs = [ llvmPackages.clang-unwrapped llvmPackages.llvm libxml2 zlib ];
+  buildInputs = [ llvmPackages.clang-unwrapped llvmPackages.llvm llvmPackages.lld libxml2 zlib ];
 
   preBuild = ''
     export HOME=$TMPDIR;
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 30bc0af360e..f0ab0586955 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -15147,7 +15147,7 @@ in
   zmqpp = callPackage ../development/libraries/zmqpp { };
 
   zig = callPackage ../development/compilers/zig {
-    llvmPackages = llvmPackages_9;
+    llvmPackages = llvmPackages_10;
   };
 
   zimlib = callPackage ../development/libraries/zimlib { };

[yrashk]

I was able to devise a quick-and-dirty workaround to make it possible to build master with Nixpkgs (with NixOS/nixpkgs#83350 merged)

diff --git a/pkgs/development/compilers/zig/default.nix b/pkgs/development/compilers/zig/default.nix
index 961e28da82e..ed521a0e70a 100644
--- a/pkgs/development/compilers/zig/default.nix
+++ b/pkgs/development/compilers/zig/default.nix
@@ -1,18 +1,25 @@
 { stdenv, fetchFromGitHub, cmake, llvmPackages, libxml2, zlib }:
 
 stdenv.mkDerivation rec {
-  version = "0.5.0";
+  version = "547ba8eb203fa84d207eb38d8d64c0f7f3162101";
   pname = "zig";
 
   src = fetchFromGitHub {
     owner = "ziglang";
     repo = pname;
     rev = version;
-    sha256 = "0xyl0riakh6kwb3yvxihb451kqs4ai4q0aygqygnlb2rlr1dn1zb";
+    sha256 = "1qvaky2h4j0bss7qjcwiz7q3jhrwlhbjyjgg91zjp9rz5sx2a24k";
   };
 
   nativeBuildInputs = [ cmake ];
-  buildInputs = [ llvmPackages.clang-unwrapped llvmPackages.llvm libxml2 zlib ];
+  buildInputs = [ llvmPackages.clang-unwrapped llvmPackages.llvm llvmPackages.lld libxml2 zlib ];
+
+  patches = [ ./llvm10_poly.patch ] ;
+
+  postPatch = ''
+    export llvm_extras=-Wl,${llvmPackages.llvm}/lib/LLVMPolly.so
+    substituteAllInPlace CMakeLists.txt
+  '';
 
   preBuild = ''
     export HOME=$TMPDIR;
diff --git a/pkgs/development/compilers/zig/llvm10_poly.patch b/pkgs/development/compilers/zig/llvm10_poly.patch
new file mode 100644
index 00000000000..873c825dfbc
--- /dev/null
+++ b/pkgs/development/compilers/zig/llvm10_poly.patch
@@ -0,0 +1,10 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 97608cddf..e451c0711 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -369,6 +369,7 @@ target_link_libraries(zig_cpp LINK_PUBLIC
+     ${CLANG_LIBRARIES}
+     ${LLD_LIBRARIES}
+     ${LLVM_LIBRARIES}
++    @llvm_extras@
+ )
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 30bc0af360e..f0ab0586955 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -15147,7 +15147,7 @@ in
   zmqpp = callPackage ../development/libraries/zmqpp { };
 
   zig = callPackage ../development/compilers/zig {
-    llvmPackages = llvmPackages_9;
+    llvmPackages = llvmPackages_10;
   };
 
   zimlib = callPackage ../development/libraries/zimlib { };

[josephg]

I run into the same problem installing zig --HEAD from homebrew on macos:

 $ brew install zig --HEAD
Updating Homebrew...
==> Cloning https://github.com/ziglang/zig.git
Cloning into '/Users/josephg/Library/Caches/Homebrew/zig--git'...
Updating files: 100% (9367/9367), done.
==> Checking out branch master
Already on 'master'
Your branch is up to date with 'origin/master'.
==> cmake .
==> make install
Last 15 lines from /Users/josephg/Library/Logs/Homebrew/zig/02.make:
[ 98%] Building CXX object CMakeFiles/zig0.dir/src/stage2.cpp.o
/usr/local/Homebrew/Library/Homebrew/shims/mac/super/clang++  -DNDEBUG -isysroot /Library/Developer/CommandLineTools/SDKs/MacOSX10.15.sdk -Wl,-search_paths_first -Wl,-headerpad_max_install_names   CMakeFiles/zig0.dir/src/main.cpp.o CMakeFiles/zig0.dir/src/stage2.cpp.o  -o zig0 [...]
Undefined symbols for architecture x86_64:
  "getPollyPluginInfo()", referenced from:
      (anonymous namespace)::EmitAssemblyHelper::EmitAssemblyWithNewPassManager(clang::BackendAction, std::__1::unique_ptr<llvm::raw_pwrite_stream, std::__1::default_delete<llvm::raw_pwrite_stream> >) in libclangCodeGen.a(BackendUtil.cpp.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [zig0] Error 1
make[1]: *** [CMakeFiles/zig0.dir/all] Error 2
make: *** [all] Error 2

[fengb]

Homebrew fix: Homebrew/homebrew-core#52352

[yrashk]

LLVM 10 release is in Nixpkgs now NixOS/nixpkgs#83350

[josephg]

:/ That homebrew fix didn't work (see the issue), and adding "-Wl,/usr/local/opt/llvm/lib/libPolly.so" gives me this error:

$ make 
Configuring zig version 0.5.0+f6d384450
-- Configuring done
-- Generating done
-- Build files have been written to: /Users/josephg/3rdparty/zig/build
[ 76%] Built target embedded_softfloat
[ 80%] Built target zig_cpp
[ 82%] Built target opt_c_util
[ 97%] Built target zigcompiler
[ 98%] Linking CXX executable zig0
ld: can't link with bundle (MH_BUNDLE) only dylibs (MH_DYLIB) file '/usr/local/opt/llvm/lib/LLVMPolly.so' for architecture x86_64
clang-10: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [zig0] Error 1
make[1]: *** [CMakeFiles/zig0.dir/all] Error 2
make: *** [all] Error 2

---

EDIT

Linking to all the static versions of the library worked. In CMakeLists.txt:

target_link_libraries(zig_cpp LINK_PUBLIC
    ${CLANG_LIBRARIES}
    ${LLD_LIBRARIES}
    ${LLVM_LIBRARIES}
    "-Wl,/usr/local/opt/llvm/lib/libPolly.a"
    "-Wl,/usr/local/opt/llvm/lib/libPollyPPCG.a"
    "-Wl,/usr/local/opt/llvm/lib/libPollyISL.a"
)

[timmyjose]

@josephg
Thank you so much! It has been frustrating waiting for the Homebrew team to fix the issue. I was making do with the latest binary from master. This should work nicely till that issue is fixed upstream. Cheers!