Add support for --(no-)undefined-version
#18486
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castholm
changed the title
--(no-)undefined-version
Co-authored-by: Motiejus Jakštys <[email protected]> Co-authored-by: Jakub Konka <[email protected]> Co-authored-by: Samuel Cantero <[email protected]> Co-authored-by: Giorgos Georgiou <[email protected]> Co-authored-by: Carl Åstholm <[email protected]>
castholm
force-pushed
the
undefined-version
branch
from
0d11339 to
3cd6468
Compare
|
Thanks! |
ghost
pushed a commit
to uber/hermetic_cc_toolchain
that referenced
this pull request
Jan 10, 2024
linker: support `--(no-)undefined-version`: ziglang/zig#18486
motiejus
pushed a commit
to uber/hermetic_cc_toolchain
that referenced
this pull request
Jan 10, 2024
linker: support `--(no-)undefined-version`: ziglang/zig#18486
|
Thank you! This is quite a big deal for some |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #16855 (main issue)
Closes #17326 (abandoned PR)
Closes #18255 (forked PR)
Adds support for the
--(no-)undefined-versionoption, which permits/forbids references to undefined symbols in version scripts. The default is--no-undefined-version.I squashed the commit history and added linker tests (with
use_lld = truefor now), as was requested by #17326 (comment)