Skip to content

std.os.linux: Fix definition of tc_lflag_t on MIPS #21036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2024

Conversation

linusg
Copy link
Collaborator

@linusg linusg commented Aug 11, 2024

[...]/std/os/linux.zig:6558:51: error: backing integer type 'c_uint' has bit size 32 but the struct fields have a total bit size of 33
pub const tc_lflag_t = if (is_mips) packed struct(tcflag_t) {
                                                  ^~~~~~~~

cc @alexrp

@alexrp
Copy link
Member

alexrp commented Aug 11, 2024

Oops, thanks for catching this. Hopefully we can get MIPS in CI soon-ish.

@andrewrk
Copy link
Member

andrewrk commented Aug 12, 2024

Oops, thanks for catching this. Hopefully we can get MIPS in CI soon-ish.

Unfortunately LLVM has O(N^2) logic in their MIPS object file generation code, so I disabled MIPS testing in the CI. We can re-enable it by adding our own MIPS backend.

@andrewrk andrewrk merged commit 9ef16b3 into ziglang:master Aug 12, 2024
10 checks passed
@linusg linusg deleted the mips-tc-lflag-t branch August 12, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants