[WIP] LLVM 19 #21183

alexrp · 2024-08-23T23:10:19Z

Currently using LLVM 19.1.0-rc3. Following the documented process.

Things to be done:

Add ProcessorAlias support to tools/update_cpu_features.zig.
- This is why some CPU models have gone missing in lib/std/Target/aarch64.zig, which in turn breaks macOS builds.
Add a bridgeos tag to std.Target.Os.Tag.
Investigate and fix various failures in zig build test-link.
- [WIP] LLVM 19 #21183 (comment)
Revert any workarounds that were committed for the linked issues below.
Update ThreadSanitizer sources.
- The last update for these was with LLVM 17.
- I will probably wait with doing this until LLVM 19.1.0-final is tagged since the process is a bit more annoying than the other libraries.
Re-do most of the steps when LLVM 19.1.0-final is tagged.
Figure out what to do with the @bitCast of packed struct containing pointer test.
- Context: https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179

Other than the above, we're in relatively good shape. The full test suite builds successfully for all platforms ~~(with the CPU model caveat above)~~ and, other than the test-link failures, runs successfully for all actively-tested Linux triples (with QEMU and multi-glibc) and macOS. Still need to run tests on Windows.

Closes #12011.
Closes #16177.
Closes #17381.
Closes #17514.
Closes #17902.
Closes #18872.
Closes #21064.
Closes #21336.

CI results completely irrelevant at this stage.

Rexicon226 · 2024-08-23T23:12:46Z

I don't have a macOS machine so I would very much appreciate if someone who does could try to run the test suite on one. I do have a Windows machine, but it would take me some time to set up a dev environment there, so would also appreciate any testers there.

Can test on an M3 Pro, give me a couple hours.

lib/std/Target/riscv.zig

Rexicon226 · 2024-08-30T14:24:35Z

@Luukdegram I'm silly and accidentally force-pushed before pulling your commit locally yesterday. I redid it from memory and attributed it to you in e632e71; hopefully it's ok. Also, can you verify that aeaefba is correct?

e948d89

alexrp · 2024-08-30T18:37:58Z

This branch now passes the full test suite on Linux. It would be great if someone with a Windows dev environment already set up would be willing to build and test the branch.

Luukdegram · 2024-08-31T06:34:15Z

@Luukdegram I'm silly and accidentally force-pushed before pulling your commit locally yesterday. I redid it from memory and attributed it to you in e632e71; hopefully it's ok. Also, can you verify that aeaefba is correct?

No worries! Both changes look good.

alexrp · 2024-09-03T15:35:26Z

Just FYI, 19.1.0-final got pushed back by 2 weeks: https://discourse.llvm.org/t/llvm-19-1-0-rc4-released/81039

Co-authored-by: David Rubin <[email protected]>

* Moved the tz.cpp patch to experimental/tzdb.cpp. * Extended the __config_site patch to a few more files.

* Add `ProcessorAlias` support. * Bump output buffer size. * Include `i` extension in RISC-V baselines. * Update evaluation branch quota for RISC-V. * Retain some CPU features that LLVM removed. * Flatten more 'meta-features' used for CPU models. * Remove some superfluous dependencies.

…cpus misuse.

This is no longer supported in LLVM 19; fall back to the generic code path.

@as

…ily. TODO: Figure out what to do about this. Context: https://discourse.llvm.org/t/rfc-remove-most-constant-expressions/63179 After changing our emit strategy for packed structs to just write to memory: test-behavior └─ run test behavior-x86_64-linux.6.5...6.5-gnu.2.38-x86_64-ReleaseSmall-libc └─ zig test ReleaseSmall native failure error: thread 44346 panic: attempt to unwrap error: ReinterpretDeclRef /home/alexrp/Source/zig/src/Value.zig:571:42: 0x1f33514 in writeToPackedMemory (zig) if (!val.ptrHasIntAddr(mod)) return error.ReinterpretDeclRef; ^ /home/alexrp/Source/zig/src/Value.zig:548:17: 0x1f32f45 in writeToPackedMemory (zig) try field_val.writeToPackedMemory(field_ty, pt, buffer, bit_offset + bits); ^ /home/alexrp/Source/zig/src/codegen/llvm.zig:3706:89: 0x1ca2366 in lowerValueToInt (zig) val.writeToPackedMemory(ty, pt, std.mem.sliceAsBytes(limbs)[0..bytes], 0) catch unreachable; ^ /home/alexrp/Source/zig/src/codegen/llvm.zig:4083:49: 0x1a33800 in lowerValue (zig) return o.lowerValueToInt(llvm_int_ty, arg_val); ^ /home/alexrp/Source/zig/src/codegen/llvm.zig:4798:42: 0x2ec4e6a in resolveValue (zig) const llvm_val = try o.lowerValue(val.toIntern()); ^ /home/alexrp/Source/zig/src/codegen/llvm.zig:4789:47: 0x2ec4bd3 in resolveInst (zig) const llvm_val = try self.resolveValue((try self.air.value(inst, self.ng.object.pt)).?); ^ /home/alexrp/Source/zig/src/codegen/llvm.zig:8996:49: 0x2f022e9 in airStore (zig) const src_operand = try self.resolveInst(bin_op.rhs); ^ /home/alexrp/Source/zig/src/codegen/llvm.zig:4967:53: 0x29f7260 in genBody (zig) .store => try self.airStore(inst, false), ^ /home/alexrp/Source/zig/src/codegen/llvm.zig:1682:19: 0x29f147c in updateFunc (zig) fg.genBody(air.getMainBody()) catch |err| switch (err) { ^ /home/alexrp/Source/zig/src/link/Elf.zig:2916:70: 0x2eb0f15 in updateFunc (zig) if (self.llvm_object) |llvm_object| return llvm_object.updateFunc(pt, func_index, air, liveness); ^ /home/alexrp/Source/zig/src/link.zig:426:82: 0x29fbef5 in updateFunc (zig) return @as(*tag.Type(), @fieldParentPtr("base", base)).updateFunc(pt, func_index, air, liveness); ^ /home/alexrp/Source/zig/src/Zcu/PerThread.zig:876:22: 0x25f3d9e in linkerUpdateFunc (zig) lf.updateFunc(pt, func_index, air, liveness) catch |err| switch (err) { ^ /home/alexrp/Source/zig/src/Compilation.zig:3975:36: 0x21768fe in processOneCodegenJob (zig) try pt.linkerUpdateFunc(func.func, func.air); ^ /home/alexrp/Source/zig/src/Compilation.zig:3928:36: 0x2176541 in queueCodegenJob (zig) return processOneCodegenJob(tid, comp, codegen_job); ^ /home/alexrp/Source/zig/src/Compilation.zig:3682:37: 0x1e9d37f in processOneJob (zig) try comp.queueCodegenJob(tid, .{ .func = .{ ^ /home/alexrp/Source/zig/src/Compilation.zig:3638:30: 0x1c1f6c1 in performAllTheWorkInner (zig) try processOneJob(@intFromEnum(Zcu.PerThread.Id.main), comp, job, main_progress_node); ^ /home/alexrp/Source/zig/src/Compilation.zig:3508:36: 0x1ab6e10 in performAllTheWork (zig) try comp.performAllTheWorkInner(main_progress_node); ^ /home/alexrp/Source/zig/src/Compilation.zig:2269:31: 0x1ab25b9 in update (zig) try comp.performAllTheWork(main_progress_node); ^ /home/alexrp/Source/zig/src/main.zig:4156:32: 0x1b01351 in serve (zig) try comp.update(main_progress_node); ^ /home/alexrp/Source/zig/src/main.zig:3453:22: 0x1b20d7c in buildOutputType (zig) try serve( ^ /home/alexrp/Source/zig/src/main.zig:267:31: 0x1969c54 in mainArgs (zig) return buildOutputType(gpa, arena, args, .zig_test); ^ /home/alexrp/Source/zig/src/main.zig:199:20: 0x19669c5 in main (zig) return mainArgs(gpa, arena, args); ^ /home/alexrp/Source/zig/lib/std/start.zig:614:37: 0x19664ee in main (zig) const result = root.main() catch |err| { ^ ../sysdeps/nptl/libc_start_call_main.h:58:16: 0x7a453da2814f in __libc_start_call_main (../sysdeps/x86/libc-start.c) ../csu/libc-start.c:360:3: 0x7a453da28208 in __libc_start_main_impl (../sysdeps/x86/libc-start.c) ???:?:?: 0x1966134 in ??? (???) ???:?:?: 0x0 in ??? (???)

Closes ziglang#18872.

Closes ziglang#16177.

This reverts commit 234693b.

This partially reverts commit ab4d6bf.

andrewrk · 2024-09-05T21:29:22Z

Merged into llvm19 branch.

alexrp · 2024-09-20T05:55:32Z

Merged into master in c6ad452.

This comment was marked as resolved.

Sign in to view

alexrp force-pushed the llvm-19 branch from 7d171ad to 0ac1fe3 Compare August 25, 2024 22:11

This comment was marked as resolved.

Sign in to view

alexrp force-pushed the llvm-19 branch from 74baef6 to 1237128 Compare August 29, 2024 08:34

Rexicon226 reviewed Aug 29, 2024

View reviewed changes

lib/std/Target/riscv.zig Outdated Show resolved Hide resolved

alexrp force-pushed the llvm-19 branch 2 times, most recently from adf34b7 to aeaefba Compare August 30, 2024 14:20

This comment was marked as resolved.

Sign in to view

alexrp mentioned this pull request Aug 30, 2024

std.crypto.ml_kem tests are very slow, especially under QEMU #21255

Closed

alexrp mentioned this pull request Aug 31, 2024

Fix soft float support, split musl triples by float ABI, and enable CI #21269

Merged

alexrp and others added 13 commits September 5, 2024 22:03

cmake: Update to LLVM 19.

f04d2c1

Co-authored-by: David Rubin <[email protected]>

compiler: Update LLVM/Clang driver files to LLVM/Clang 19.

adfd150

zig_llvm: Update to LLVM 19.

c3140e2

zig_clang: Update to Clang 19.

9a7cc0d

Co-authored-by: David Rubin <[email protected]>

clang: Update options data to Clang 19.

707b521

clang: Update compiler-provided C headers to Clang 19.

fb06671

libunwind: Update to LLVM 19.

83c7126

libunwind: Synchronize some CFLAGS/CXXFLAGS with upstream.

e10dd31

libcxxabi: Update to LLVM 19.

9d88e00

libcxx: Update to LLVM 19.

8504e23

* Moved the tz.cpp patch to experimental/tzdb.cpp. * Extended the __config_site patch to a few more files.

libcxx: Synchronize some CXXFLAGS with upstream.

989132f

update_cpu_features: Fix feature_overrides logic and replace an omit_…

6264734

…cpus misuse.

alexrp and others added 12 commits September 5, 2024 22:03

std.Target: Update CPU models/features for LLVM 19.

d5ee409

llvm: Stop emitting shl/xor ops for constant packed structs.

b932583

This is no longer supported in LLVM 19; fall back to the generic code path.

std.Target: Add bridgeos tag to Os.

e0923af

Compilation: Synchronize some libcxx CXXFLAGS with upstream.

e5cb569

link.Wasm.Feature: Update to mirror std.Target.wasm.

d6abf47

test: Update wasm/infer-features based on what LLVM produces.

0f183ba

std.zig.system.darwin.macos: Enable Apple M4 CPU detection.

3ba200b

test: Re-enable LLVM riscv64 module tests.

c1bed62

Closes ziglang#18872.

test: Re-enable store vector with memset for LLVM.

6f4fbf5

Closes ziglang#16177.

Revert "tests: skip native CPU std tests on Windows"

73f46ca

This reverts commit 234693b.

Partially revert "LLVM: work around @floatFromInt bug"

3704ad0

This partially reverts commit ab4d6bf.

alexrp force-pushed the llvm-19 branch from 00c8d7e to 3704ad0 Compare September 5, 2024 20:03

alexrp closed this Sep 20, 2024

alexrp deleted the llvm-19 branch September 20, 2024 07:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] LLVM 19 #21183

[WIP] LLVM 19 #21183

alexrp commented Aug 23, 2024 •

edited

Loading

This comment was marked as resolved.

Rexicon226 commented Aug 23, 2024

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Rexicon226 commented Aug 30, 2024

alexrp commented Aug 30, 2024

Luukdegram commented Aug 31, 2024

alexrp commented Sep 3, 2024

andrewrk commented Sep 5, 2024

alexrp commented Sep 20, 2024

[WIP] LLVM 19 #21183

[WIP] LLVM 19 #21183

Conversation

alexrp commented Aug 23, 2024 • edited Loading

This comment was marked as resolved.

Rexicon226 commented Aug 23, 2024

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

This comment was marked as resolved.

Rexicon226 commented Aug 30, 2024

alexrp commented Aug 30, 2024

Luukdegram commented Aug 31, 2024

alexrp commented Sep 3, 2024

andrewrk commented Sep 5, 2024

alexrp commented Sep 20, 2024

alexrp commented Aug 23, 2024 •

edited

Loading