test: Revert 7437c47d55da4c73aba26327d1a140aaf6591d4a#24360
Closed
alexrp wants to merge 1 commit intoziglang:masterfrom
alexrp:revert-8734-workaround
Closed
test: Revert 7437c47d55da4c73aba26327d1a140aaf6591d4a#24360alexrp wants to merge 1 commit intoziglang:masterfrom alexrp:revert-8734-workaround
test: Revert 7437c47d55da4c73aba26327d1a140aaf6591d4a#24360alexrp wants to merge 1 commit intoziglang:masterfrom
alexrp:revert-8734-workaround
Conversation
Closes #8734.
andrewrk
requested changes
Jul 7, 2025
Member
andrewrk
left a comment
andrewrk
left a comment
There was a problem hiding this comment.
Behavior tests must not use expectEqual. It depends too much on std lib.
Member
Author
|
Are you suggesting simply closing #8734 then? Also FWIW: |
Member
|
Best case scenario, add behavior test coverage for it that does not depend on expectEqual, and does a minimal reproduction of the issue. Or also acceptable, just close the issue and count on fuzzing to catch all such bugs later. |
Member
I'm aware 🥲 |
Member
Author
I say we go with this then, because there's no readily available repro anywhere that I can find. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8734.