Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions .env.testing-artifacts
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,7 @@
# rust-toolchain.toml's `channel`; consumers derive it via
# the workbench get-rust-version bin.

# zcashd Git tag (https://github.com/zcash/zcash/releases)
ZCASH_VERSION=6.20.0

ZEBRA_VERSION=6.0.0-rc.0
ZEBRA_VERSION=6.0.0

# zcash-devtool git ref (https://github.com/zingolabs/zcash-devtool) —
# the wallet client driven by wallet-tests via zcash_local_net, built
Expand Down
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/bug_report.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ body:
description: |
Please include:
- Zaino version or commit hash
- Backend version (zebra/zcashd)
- Backend version (zebra)
- OS and platform
placeholder: |
Zaino: v0.x.x or commit abc123
Expand Down
6 changes: 2 additions & 4 deletions .github/workflows/build-n-push-ci-image.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
run: |
source .env.testing-artifacts
RUST_VERSION=$(cargo run -q --manifest-path tools/workbench/Cargo.toml --bin get-rust-version)
export RUST_VERSION ZCASH_VERSION ZEBRA_VERSION DEVTOOL_VERSION
export RUST_VERSION ZEBRA_VERSION DEVTOOL_VERSION
TAG=$(./tools/scripts/get-ci-image-tag.sh)
echo "tag=$TAG" >> "$GITHUB_OUTPUT"

Expand All @@ -55,7 +55,6 @@ jobs:
ZEBRA_GIT_REF=$(cargo run -q --manifest-path tools/workbench/Cargo.toml --bin get-zebra-git-ref -- "$ZEBRA_VERSION")
echo "sha_short=$(git rev-parse --short HEAD)" >> "$GITHUB_OUTPUT"
echo "RUST_VERSION=$RUST_VERSION" >> "$GITHUB_ENV"
echo "ZCASH_VERSION=$ZCASH_VERSION" >> "$GITHUB_ENV"
echo "ZEBRA_VERSION=$ZEBRA_VERSION" >> "$GITHUB_ENV"
echo "ZEBRA_GIT_REF=$ZEBRA_GIT_REF" >> "$GITHUB_ENV"
echo "DEVTOOL_VERSION=$DEVTOOL_VERSION" >> "$GITHUB_ENV"
Expand All @@ -65,7 +64,7 @@ jobs:
run: |
set -a
source ./tools/scripts/helpers.sh
TARGET=$(resolve_build_target ${{ env.ZCASH_VERSION }} ${{ env.ZEBRA_VERSION }})
TARGET=$(resolve_build_target ${{ env.ZEBRA_VERSION }})
echo "target=$TARGET" >> "$GITHUB_OUTPUT"

- name: Build and Push Docker Image
Expand All @@ -82,7 +81,6 @@ jobs:
push: ${{ github.event_name != 'workflow_dispatch' || inputs.push }}
build-args: |
RUST_VERSION=${{ env.RUST_VERSION }}
ZCASH_VERSION=${{ env.ZCASH_VERSION }}
ZEBRA_VERSION=${{ env.ZEBRA_VERSION }}
ZEBRA_GIT_REF=${{ env.ZEBRA_GIT_REF }}
DEVTOOL_VERSION=${{ env.DEVTOOL_VERSION }}
39 changes: 2 additions & 37 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -101,38 +101,6 @@ jobs:
compute-tag:
uses: ./.github/workflows/compute-tag.yml

no-zcashd-build:
name: No-zcashd build (--no-default-features)
# The default-on `zcashd_support` feature is being deprecated; its OFF
# state must keep compiling or the deprecation path bit-rots. Runs in the
# CI container (toolchain + git deps + cargo cache) like the build job, so
# it is skipped on PRs until a self-hosted runner is available — same as the
# other compiling jobs. See docs/adr/0001-zcashd-support-feature-gate.md.
needs: compute-tag
container:
image: docker.io/zingodevops/zaino-ci:${{ needs.compute-tag.outputs.image-tag }}
runs-on: arc-sh-runners
if: github.event_name != 'pull_request' && github.event.pull_request.draft == false
steps:
- name: Checkout repository
uses: actions/checkout@v7

- name: Restore cargo dependencies
uses: tespkg/actions-cache/restore@v1
with:
endpoint: ${{ env.CACHE_ENDPOINT }}
port: ${{ env.CACHE_PORT }}
bucket: ${{ env.CACHE_BUCKET }}
insecure: ${{ env.INSECURE_CACHE }}
key: cargo-deps-${{ hashFiles('**/Cargo.lock') }}
restore-keys: cargo-deps-
path: |
~/.cargo
target/debug/deps

- name: Check no-zcashd build across all three workspaces
run: makers check-no-zcashd

build-test-artifacts:
name: Build test artifacts
needs: compute-tag
Expand Down Expand Up @@ -166,8 +134,6 @@ jobs:
# test crates' own dependency declarations and survive feature
# unification, so the harness still functions. This deliberately omits
# the product features `--all-features` was speculatively enabling:
# - zcashd_support (opt-in; docs/adr/0001, 0005): zcashd is being
# deprecated; zcashd-backed tests cfg out and are not executed in CI.
# - experimental_features / transparent_address_history_experimental:
# not shipped on by default; CI should not gate on a non-release combo.
# - prometheus.
Expand Down Expand Up @@ -211,11 +177,10 @@ jobs:
# - "clientless::chain_cache" # disabled: timeouts/hangs pending chain-index
# integration; re-enable per https://github.com/zingolabs/zaino/issues/1312
- "clientless::fetch_service"
- "clientless::json_server"
- "clientless::state_service"
- "clientless::test_vectors"
# NOTE: the e2e partition (e2e::devtool, e2e::devtool_zcashd,
# e2e::test_vectors) now lives in the unified --workspace archive and
# NOTE: the e2e partition (e2e::devtool, e2e::test_vectors) now
# lives in the unified --workspace archive and
# is compiled every run, but is intentionally NOT executed here —
# adding the validator-heavy e2e suite to this job is a CI-capacity
# decision tracked in https://github.com/zingolabs/zaino/issues/1308.
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/compute-tag.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
run: |
source .env.testing-artifacts
RUST_VERSION=$(cargo run -q --manifest-path tools/workbench/Cargo.toml --bin get-rust-version)
export RUST_VERSION ZCASH_VERSION ZEBRA_VERSION DEVTOOL_VERSION DOCKER_DIR_HASH
export RUST_VERSION ZEBRA_VERSION DEVTOOL_VERSION DOCKER_DIR_HASH
TAG=$(./tools/scripts/get-ci-image-tag.sh)
echo "TAG=$TAG"
echo "tag=$TAG" >> "$GITHUB_OUTPUT"
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ Error handling must be included and expose underlying information as much as and

Merges must minimally reflect the zcash RPC spec and include a link to the relevant zcash C++ implementation (URLs that point at the analogous logic), OR reflect the C++ implementation.

Tests are encouraged that show parity bewteen responses from `zcash-cli` + `zcashd` and `zaino`+ a `zebra` backend, and the local cache.
Tests are encouraged that show parity between responses from `zaino` + a `zebra` backend and the local cache.

## Local Testing
Local testing requires a system with ample resources, particularly RAM.
Expand Down
Loading
Loading