test(client): remove mirror
#314
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dart test, either in flutter or web browser, does not support mirror, see dart-lang/sdk#30538 and flutter/flutter#1150. Using `Directory.current.path` might still be problematic for web browser later on, but now let's focus on flutter only.
micimize
approved these changes
May 31, 2019
|
@HofmannZ lack of |
|
closing in favor of #323 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dart test, either in flutter or web browser, does not support mirror,
see dart-lang/sdk#30538 and
flutter/flutter#1150.
Using
Directory.current.pathmight still be problematic for web browser later on,but now let's focus on flutter only.