onNotification is not calling when app is in background

[rizwanshaikh199091]

Bug

When I am calling fcm server push notification api data is not showing on onNotification function.

Environment info

react-native info output:

 // paste it here

Library version: 3.4.0

Steps To Reproduce

I use the following code for recieving push notification

1. Call the service from postman collection for fcm
2. we got data in onNotification when app is in foreground but not in backgorund
   ...

Describe what you expected to happen:

Reproducible sample code

PushNotification.configure({
// (optional) Called when Token is generated (iOS and Android)
onRegister: function (token) {
console.log("TOKEN:", token);
thats.setState({deviceToken:token});
},

  // (required) Called when a remote or local notification is opened or received
  onNotification: function (notification) {
    

    console.log('** NOTIFICATION: **', notification);

  if (Platform.OS === 'ios') {
    if (notification.alert.length !== 0) {
      //handleNotification(notification)
      notification.finish(PushNotificationIOS.FetchResult.NoData);
    }
  } else {
    //handleNotification(notification)
  }

  
  },

  // IOS ONLY (optional): default: all - Permissions to register.
  permissions: {
    alert: true,
    badge: true,
    sound: true,
  },

  // Should the initial notification be popped automatically
  // default: true
  popInitialNotification: true,

 
  requestPermissions: true,
});

PushNotification.popInitialNotification((notification) => { 
  console.log(notification); 
})

[Dallas62]

Hi @rizwanshaikh199091
Can you provide more information ?
Where did you put PushNotification.configure ? Inside a component ?
Can you reproduce it in example project ?

[rizwanshaikh199091]

Hi @Dallas62

Thanks for quick reply, I put my code inside constructor function.

This is the code that I put inside constructor function of my call and calling api from postman.

    PushNotification.configure({
      // (optional) Called when Token is generated (iOS and Android)
      onRegister: function (token) {
        console.log("TOKEN:", token);
        thats.setState({deviceToken:token});
      },
    
      // (required) Called when a remote or local notification is opened or received
      onNotification: function (notification) {
        

        console.log('** NOTIFICATION: **', notification);

      if (Platform.OS === 'ios') {
        if (notification.alert.length !== 0) {
          //handleNotification(notification)
          notification.finish(PushNotificationIOS.FetchResult.NoData);
        }
      } else {
        //handleNotification(notification)
      }

      
      },
    
      // IOS ONLY (optional): default: all - Permissions to register.
      permissions: {
        alert: true,
        badge: true,
        sound: true,
      },
    
      // Should the initial notification be popped automatically
      // default: true
      popInitialNotification: true,
    
     
      requestPermissions: true,
    });

    PushNotification.popInitialNotification((notification) => { 
      console.log(notification); 
    })

I have attached a few screenshots taken in both the conditions. Please have a look.

Please advice. Thanks

[Dallas62]

Hi @Dallas62

Thanks for quick reply, I put my code inside constructor function.

This is the code that I put inside constructor function of my call and calling api from postman.

I have attached a few screenshots taken in both the conditions. Please have a look.

Please advice. Thanks

I think you should put the PushNotification.configure Outside of a component,
Take a look at example

[rizwanshaikh199091]

Okay let me try this

[davidsalib]

I'm having the same issue. Tried it both in componentDidMount and outside of a component. Same issue.

[Dallas62]

Okay let me try this

I didn't notice, but in your screenshot there is the data, which means you received the notification, so everything is OK, no ?

https://firebase.google.com/docs/cloud-messaging/android/receive#handling_messages

onMessageReceived is provided for most message types, with the following exceptions:

Notification messages delivered when your app is in the background: In this case, the notification is delivered to the device’s system tray. A user tap on a notification opens the app launcher by default.

Messages with both notification and data payload, when received in the background: In this case, the notification is delivered to the device’s system tray, and the data payload is delivered in the extras of the intent of your launcher Activity.

App state	Notification	Data	Both
Foreground	onMessageReceived	onMessageReceived	onMessageReceived
Background	System tray	onMessageReceived	Notification: system trayData: in extras of the intent.

I know this is not what you expect, but I don't think we can change this.

[taymer]

Same issue here, I tried with the example app and onNotification is always called except when app is in backgroud.
The App is just cloned from git example.
I'm trying it in an Android 7.0 device

[taymer]

Ok, i figured it out: the problem is that onNewIntent() is not called on ReactContextBaseJavaModule
This solution worked in the example app: https://stackoverflow.com/a/45749359/829300

I modified
public class RNPushNotification implementing Application.ActivityLifecycleCallbacks and overriding

public void onActivityStarted(Activity activity) {
    Intent intent = activity.getIntent();
    Bundle bundle = this.getBundleFromIntent(intent);
    if (bundle != null) {
        bundle.putBoolean("foreground", false);
        intent.putExtra("notification", bundle);
        mJsDelivery.notifyNotification(bundle);
    }
}

[wbercx]

public void onActivityStarted(Activity activity) {
    Intent intent = activity.getIntent();
    Bundle bundle = this.getBundleFromIntent(intent);
    if (bundle != null) {
        bundle.putBoolean("foreground", false);
        intent.putExtra("notification", bundle);
        mJsDelivery.notifyNotification(bundle);
    }
}

@taymer This appears to be a source of crashes now. I've received the following stacktrace a number of times over the weekend (Release build).

I assume this means mJsDelivery may not always be initialised when onActivityStarted runs.

java.lang.NullPointerException: Attempt to invoke virtual method 'void com.dieam.reactnativepushnotification.modules.d.c(android.os.Bundle)' on a null object reference
  at com.dieam.reactnativepushnotification.modules.RNPushNotification.onActivityStarted(RNPushNotification.java:5)
  at android.app.Application.dispatchActivityStarted(Application.java:406)
  at android.app.Activity.dispatchActivityStarted(Activity.java:1239)
  at android.app.Activity.onStart(Activity.java:1724)
  at androidx.fragment.app.d.onStart(FragmentActivity.java:1)
  at androidx.appcompat.app.e.onStart(AppCompatActivity.java:1)
  at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1432)
  at android.app.Activity.performStart(Activity.java:7848)
  at android.app.ActivityThread.handleStartActivity(ActivityThread.java:3294)
  at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:221)
  at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:201)
  at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:173)
  at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:97)
  at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2016)
  at android.os.Handler.dispatchMessage(Handler.java:107)
  at android.os.Looper.loop(Looper.java:214)
  at android.app.ActivityThread.main(ActivityThread.java:7356)
  at java.lang.reflect.Method.invoke(Method.java:-2)
  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:492)
  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:930)

[Dallas62]

Hi @wbercx
Can you provide the android:launchMode of your activity ?

[wbercx]

@Dallas62 singleTop.

I do not remember the exact reason why though. I feel like I've had to mess with that a few times over the years. I wrote a particularly useless commit message for that too...

EDIT:
I ended up making the following change. Not an Android developer, so I don't know if it makes a real difference, but at least it is not broken. Then again, the original worked for me as well.

    public RNPushNotification(ReactApplicationContext reactContext) {
        super(reactContext);

        reactContext.addActivityEventListener(this);

+        // This is used to delivery callbacks to JS. Instantiated before registering activityLifeCycleCallbacks.
+        mJsDelivery = new RNPushNotificationJsDelivery(reactContext);

        Application applicationContext = (Application) reactContext.getApplicationContext();
        applicationContext.registerActivityLifecycleCallbacks(this);

        // The @ReactNative methods use this
        mRNPushNotificationHelper = new RNPushNotificationHelper(applicationContext);
-        // This is used to delivery callbacks to JS
-        mJsDelivery = new RNPushNotificationJsDelivery(reactContext);

        mRNPushNotificationHelper.checkOrCreateDefaultChannel();
    }

[Dallas62]

@wbercx
Ok, I reverted the PR and changed the code in the JS side, this might be good.
I do more tests and release a fix ASAP