Skip to content
This repository was archived by the owner on Jan 14, 2025. It is now read-only.

Keep interface parity with PushNotificationIOS#909

Merged
Dallas62 merged 3 commits intozo0r:masterfrom
NumberAI:master
Apr 26, 2020
Merged

Keep interface parity with PushNotificationIOS#909
Dallas62 merged 3 commits intozo0r:masterfrom
NumberAI:master

Conversation

@sginn
Copy link
Copy Markdown
Contributor

@sginn sginn commented Oct 17, 2018

PushNotificationIOS implements removeAllDeliveredNotifications, getDeliveredNotifications and removeDeliveredNotifications.

React-native-push-notification is a wrapper over that interface for iOS. keeping parity avoids some Platform checks

sginn added 2 commits October 17, 2018 09:06
on iOS will continue to pass through to PushNotificationIOS, but android will leverage NotificationManager to retrieve and cancel relevant notifications.
@sginn
Copy link
Copy Markdown
Contributor Author

sginn commented Oct 17, 2018

Just saw there is a ticket for this: #427

And one of the methods was implemented in another PR: #636

Welcome any and all feedback and guidance on how to get this merged in.

@Dallas62 Dallas62 self-assigned this Apr 24, 2020
@sginn
Copy link
Copy Markdown
Contributor Author

sginn commented Apr 24, 2020

Thanks @Dallas62 for jumping into this one. I had forgotten it was here.

Anything I can do to help get this merged in?

@Dallas62
Copy link
Copy Markdown
Collaborator

Dallas62 commented Apr 24, 2020

Hi @sginn
I will test the code then merge the PR ASAP

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants