Refactor download history popup to support multiple windows#553
Merged
Conversation
Google App windows now show the same Download button + recently-completed chip as the main window. Clicking it toggles the recent-downloads popup anchored to the window that triggered it. Download-completion and config-change IPCs now broadcast to all chrome windows so the chip and history resolve correctly in either renderer. https://claude.ai/code/session_01FCKbXY2185E7Jk4QxxVuQA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the download history popup system to be window-agnostic, allowing the popup to be opened from any window rather than being tied to the main window. This enables better support for multi-window scenarios and improves code maintainability.
Key Changes
mainfrom downloads.ts and replaced hardcoded references tomain.windowwith aparentWindowparameter passed at runtimerecentDownloadHistoryParentWindowfield to track which window owns the current popup, enabling proper cleanup and bounds calculationsrecentDownloadHistoryPopuptorecentDownloadHistoryViewto better reflect that it's a view, not a windowtoggleRecentDownloadHistoryPopup()to accept aBrowserWindowparameter and intelligently handle toggling (closes if same window, opens in new window if different)TitlebarIconButtoncomponent and naming (RecentDownloadHistoryButton)parentWindowBoundsas a better alternative to generic namesImplementation Details
getContentBounds()) vs other platforms (usinggetBounds())https://claude.ai/code/session_01FCKbXY2185E7Jk4QxxVuQA