Skip to content

broadcast config changes to google app windows#554

Merged
timche merged 2 commits intomainfrom
claude/fix-googleapps-config-notifications-XoOST
Apr 24, 2026
Merged

broadcast config changes to google app windows#554
timche merged 2 commits intomainfrom
claude/fix-googleapps-config-notifications-XoOST

Conversation

@timche
Copy link
Copy Markdown
Collaborator

@timche timche commented Apr 24, 2026

Summary

  • Added GoogleApp.getAllWindows() static method that returns the window for every live GoogleApp instance.
  • config.onDidAnyChange in packages/app/ipc.ts now iterates those windows and sends config.configChanged to each, so open Google app windows stay in sync with config updates (previously only the main window and the recent-downloads popup received it).
  • Renamed the GoogleApp.browserWindow property (and matching GoogleAppOptions key) to window for consistency with the new getAllWindows() API; updated all call sites in gmail/index.ts and menu.ts.

Test plan

  • Open a Google app (e.g. Docs) in its own window, change a config value from Settings, confirm the Google app window receives the update without a reload.
  • bun types:ci passes.

https://claude.ai/code/session_013sYiktrR1bBzwDnowF3S5G

@timche timche changed the title Rename browserWindow to window in GoogleApp class broadcast config changes to google app windows Apr 24, 2026
@timche timche merged commit 77ed07e into main Apr 24, 2026
7 checks passed
@timche timche deleted the claude/fix-googleapps-config-notifications-XoOST branch April 24, 2026 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants