Skip to content

Remove notification delay configuration from updates settings#555

Merged
timche merged 1 commit intomainfrom
claude/revert-update-logic-EPzBS
Apr 24, 2026
Merged

Remove notification delay configuration from updates settings#555
timche merged 1 commit intomainfrom
claude/revert-update-logic-EPzBS

Conversation

@timche
Copy link
Copy Markdown
Collaborator

@timche timche commented Apr 24, 2026

Summary

This PR removes the notification delay feature from the update notification system, simplifying the update notification logic to always notify immediately when an update is available.

Key Changes

  • Removed notification delay logic from packages/app/updater.ts:

    • Deleted NOTIFICATION_DELAY_MS configuration object
    • Removed isUrgentRelease() and flattenReleaseNotes() helper functions
    • Removed handleUpdateDownloaded(), clearPendingNotification(), and notifyRenderer() methods
    • Simplified update-downloaded handler to immediately send notification via IPC
    • Removed instance variables pendingVersion and notifyTimer
  • Removed UI controls from packages/renderer-main/routes/settings/updates.tsx:

    • Deleted the "Notification Delay" select field and its configuration
    • Removed related imports and state management code
    • Kept only the "Show Notifications" toggle
  • Updated configuration schema in packages/shared/types.ts:

    • Removed "updates.notificationDelay" type definition from Config
  • Updated default config in packages/app/config.ts:

    • Removed "updates.notificationDelay": "next-day" from defaults
    • Added migration for version >3.45.0 to clean up the setting from existing user configs

Implementation Details

The update notification system now operates in a single mode: when an update is downloaded and notifications are enabled, it immediately notifies the renderer without any delay or urgency-based logic. This reduces complexity while maintaining the core functionality of alerting users to available updates.

https://claude.ai/code/session_017K2CRC6vh3WfisvKkTm32K

Restores immediate update notifications when an update is downloaded.
Switching to a weekly release cadence removes the patch-burst problem
that the debounce was added to solve, and the immediate prompt is the
behaviour users expect.

Drops the updates.notificationDelay setting and adds a migration to
clean it from existing configs.
@timche timche merged commit 836f7c7 into main Apr 24, 2026
4 checks passed
@timche timche deleted the claude/revert-update-logic-EPzBS branch April 24, 2026 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants