Remove notification delay configuration from updates settings#555
Merged
Remove notification delay configuration from updates settings#555
Conversation
Restores immediate update notifications when an update is downloaded. Switching to a weekly release cadence removes the patch-burst problem that the debounce was added to solve, and the immediate prompt is the behaviour users expect. Drops the updates.notificationDelay setting and adds a migration to clean it from existing configs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the notification delay feature from the update notification system, simplifying the update notification logic to always notify immediately when an update is available.
Key Changes
Removed notification delay logic from
packages/app/updater.ts:NOTIFICATION_DELAY_MSconfiguration objectisUrgentRelease()andflattenReleaseNotes()helper functionshandleUpdateDownloaded(),clearPendingNotification(), andnotifyRenderer()methodspendingVersionandnotifyTimerRemoved UI controls from
packages/renderer-main/routes/settings/updates.tsx:Updated configuration schema in
packages/shared/types.ts:"updates.notificationDelay"type definition from ConfigUpdated default config in
packages/app/config.ts:"updates.notificationDelay": "next-day"from defaultsImplementation Details
The update notification system now operates in a single mode: when an update is downloaded and notifications are enabled, it immediately notifies the renderer without any delay or urgency-based logic. This reduces complexity while maintaining the core functionality of alerting users to available updates.
https://claude.ai/code/session_017K2CRC6vh3WfisvKkTm32K