Skip to content

Don't error on empty topics #116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tekknolagi wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't error on empty topics #116

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions lib/populate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,13 +148,16 @@ def populate_all(

messages = request_all(client, request)

topic_count = len(messages)
last_message = messages[-1]
latest_date = last_message["timestamp"]
if messages:
# Dump empty topics but don't try to get the latest message or
# date from them
Copy link
Copy Markdown
Member

@timabbott timabbott Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the logic behind the approach here? Empty topics are the "general chat" feature.

Copy link
Copy Markdown
Contributor Author

@tekknolagi tekknolagi Dec 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By empty I mean "does not contain messages". Our chat has a general chat that seems to contain messages on the application but messages[-1] raises an exception. So I figured we would not update the dates from non-existent messages.

Are you expecting to see no messages in "general chat"?

topic_count = len(messages)
last_message = messages[-1]
latest_date = last_message["timestamp"]

topic_data[topic_name] = dict(size=topic_count, latest_date=latest_date)
topic_data[topic_name] = dict(size=topic_count, latest_date=latest_date)

latest_id = max(latest_id, last_message["id"])
latest_id = max(latest_id, last_message["id"])

dump_topic_messages(json_root, s, topic_name, messages)

Expand Down