⌘1 sometimes stops working in other apps

[glyph]

---

Please include:

• Operating System:

  ProductName:	Mac OS X
  ProductVersion:	10.13
  BuildVersion:	17A405
  

• Clear steps to reproduce the issue:
  Run the application for a while. Eventually, the ⌘1 hotkey starts getting captured regardless of where my keyboard focus is until I restart the application.

I am only logged in to one Zulip, but if I select settings, ⌘Tab away, and then hit ⌘1 in another app when in this state, I can see it switch back to that Zulip rather than the Settings window, so I assume that for those with multiple Zulips it would globally capture ⌘2, etc.

[akashnimare]

⌘1 sometimes stops working in other apps

@glyph can you define sometimes here? Does it happen all the time or in any specific case like when you switch to other apps using ⌘Tab?

[cedricium]

@zulipbot claim

[cedricium]

Hey @glyph, I'm going to be trying to fix this issue. In addition to defining what sometimes means, is there a specific application (when you CmdTab) you're using that you see this issue happen with or is it multiple applications? I'm attempting to reproduce and haven't been able to so far. Thanks!

[timabbott]

@cedricium it seems likely the other application is irrelevant, and that the problem is that we're in some circumstance failing to unregister the hotkey from the OS...

[cedricium]

@timabbott that makes sense. I'm having trouble reproducing, am I understanding the issue correctly:

1. In Zulip app, open the Settings page. Settings page is the active window.
2. Switch to another application using CmdTab. Different application is now focused.
3. Use the Cmd1 shortcut in different application.
4. Focus the Zulip app - active window is now the first sever (no longer the Settings page).

There's some sort of timing in between switching applications and using Cmd1 which causes the issue, but is the right way to go about it?

[akashnimare]

I'm guessing this is what @glyph experiencing -

• Open Zulip app, add a server
• Open setting page
• CMD+1 should switch to the first added server (this is expected)
• Now open other app, for an example Chrome
• Press CMD+1, which should open the first tab of Chrome but instead it focuses on Zulip app and opens the first server.

I can't reproduce the last step. I'm not sure if we have to unregister CMD+1 when window loses focus, hidden etc since electron-localshortcut automatically unregister the shortcut for us.

[cedricium]

I still haven't been able to reproduce this issue, and looking at the code where the keyboard shortcuts for switching between servers gets set, I don't see anything that explicitly stands out which would cause this issue 😕

[akashnimare]

@glyph can you help us reproducing this issue. We've both tried to reproduce and read the code, and don't see how we can investigate further without more info 😕