reconnect: Check wheather internet is working before reloading. #415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priyank-p
force-pushed
the
check-internet
branch
5 times, most recently
from
2a56db7 to
68dfce6
Compare
akashnimare
reviewed
Feb 15, 2018
app/package.json
Outdated
| @@ -32,6 +32,7 @@ | |||
| "electron-spellchecker": "1.1.2", | |||
| "electron-updater": "2.18.2", | |||
| "electron-window-state": "4.1.1", | |||
| "is-online": "^7.0.0", | |||
There was a problem hiding this comment.
Should bt the exact working version here.
priyank-p
force-pushed
the
check-internet
branch
from
68dfce6 to
a6fcdf4
Compare
When online event is triggered check weather the internet is atually working or not. Commonly on windows it turns out that internet takes couple of seconds to boot up after connecting to internet or in some cases this might be they have to sign in to internet service portal in order to access internet.
priyank-p
force-pushed
the
check-internet
branch
from
a6fcdf4 to
e7ac78d
Compare
akashnimare
reviewed
Feb 15, 2018
| serverManagerView.init(); | ||
| window.addEventListener('online', () => { | ||
| serverManagerView.reloadView(); | ||
| reconnectUtil.pollInternetAndReload(); |
There was a problem hiding this comment.
Is there a need for adding a console log, just to make the debugging better (for issues like https://github.com/zulip/zulip-electron/issues/312) -
console.log('You're back online.')
console.log('No internet connection, you are offline.')
There was a problem hiding this comment.
Ah yeah, so its easier to figure out.
akashnimare
reviewed
Feb 15, 2018
| if (!this.alreadyReloaded) { | ||
| this.serverManagerView.reloadView(); | ||
| } | ||
| console.log("You're back online."); |
There was a problem hiding this comment.
console.log('You're back online.');
There was a problem hiding this comment.
Ah. i forgot to git add this :)
There was a problem hiding this comment.
I though if you had an ' inside a string that needs to escaped we can use double quotes.
priyank-p
force-pushed
the
check-internet
branch
from
bc1bd8e to
34968f9
Compare
priyank-p
force-pushed
the
check-internet
branch
from
34968f9 to
3115549
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When online event is triggered check weather the internet is atually working or not.
Commonly on windows it turns out that internet takes couple of seconds to boot up after
connecting to internet or in some cases this might be they have to sign in to internet service
portal in order to access internet.