Skip to content

Commit 5edc7a8

Browse files
committed
dialog: translations
1 parent 86753c1 commit 5edc7a8

File tree

2 files changed

+18
-4
lines changed

2 files changed

+18
-4
lines changed

assets/l10n/app_en.arb

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -75,6 +75,18 @@
7575
"@successMessageCopied": {
7676
"description": "Dialog message when content of a message was copied to the users system clipboard."
7777
},
78+
"suggestedActionDialogCancel": "Cancel",
79+
"@suggestedActionDialogCancel": {
80+
"description": "Button label to cancel a suggested action."
81+
},
82+
"suggestedActionDialogContinue": "Continue",
83+
"@suggestedActionDialogContinue": {
84+
"description": "Button label in accept a suggested action."
85+
},
86+
"errorDialogContinue": "OK",
87+
"@errorDialogContinue": {
88+
"description": "Button label in error dialogs to acknowledge error."
89+
},
7890
"subscribedToNStreams": "Subscribed to {num, plural, =0{no streams} =1{1 stream} other{{num} streams}}",
7991
"@subscribedToNStreams": {
8092
"description": "Test page label showing number of streams user is subscribed to.",

lib/widgets/dialog.dart

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import 'package:flutter/material.dart';
2+
import 'package:flutter_gen/gen_l10n/zulip_localizations.dart';
23

34
Widget _dialogActionText(String text) {
45
return Text(
@@ -14,12 +15,12 @@ Widget _dialogActionText(String text) {
1415
);
1516
}
1617

17-
// TODO(i18n): title, message, and action-button text
1818
Future<void> showErrorDialog({
1919
required BuildContext context,
2020
required String title,
2121
String? message,
2222
}) {
23+
final zulipLocalizations = ZulipLocalizations.of(context);
2324
return showDialog(
2425
context: context,
2526
builder: (BuildContext context) => AlertDialog(
@@ -28,7 +29,7 @@ Future<void> showErrorDialog({
2829
actions: [
2930
TextButton(
3031
onPressed: () => Navigator.pop(context),
31-
child: _dialogActionText('OK')),
32+
child: _dialogActionText(zulipLocalizations.errorDialogContinue)),
3233
]));
3334
}
3435

@@ -39,6 +40,7 @@ void showSuggestedActionDialog({
3940
required String? actionButtonText,
4041
required VoidCallback onActionButtonPress,
4142
}) {
43+
final zulipLocalizations = ZulipLocalizations.of(context);
4244
showDialog(
4345
context: context,
4446
builder: (BuildContext context) => AlertDialog(
@@ -47,9 +49,9 @@ void showSuggestedActionDialog({
4749
actions: [
4850
TextButton(
4951
onPressed: () => Navigator.pop(context),
50-
child: _dialogActionText('Cancel')),
52+
child: _dialogActionText(zulipLocalizations.suggestedActionDialogCancel)),
5153
TextButton(
5254
onPressed: onActionButtonPress,
53-
child: _dialogActionText(actionButtonText ?? 'Continue')),
55+
child: _dialogActionText(actionButtonText ?? zulipLocalizations.suggestedActionDialogContinue)),
5456
]));
5557
}

0 commit comments

Comments
 (0)