Skip to content

Previews when composing a message (dupe) #1001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnprice opened this issue Oct 17, 2024 · 9 comments
Closed

Previews when composing a message (dupe) #1001

gnprice opened this issue Oct 17, 2024 · 9 comments
Labels
a-compose Compose box, autocomplete, attaching files/images duplicate
Milestone

Comments

@gnprice
Copy link
Member

gnprice commented Oct 17, 2024

This is a useful feature in web:
https://zulip.com/help/preview-your-message-before-sending
and it would be useful in mobile too.

(It's not as common to want it in mobile, I think, because one tends to stick to shorter messages with simpler formatting. But that's far from absolute.)

@gnprice gnprice added the a-compose Compose box, autocomplete, attaching files/images label Oct 17, 2024
@gnprice gnprice added this to the Post-launch milestone Oct 17, 2024
@gnprice
Copy link
Member Author

gnprice commented Oct 17, 2024

@whodivyanshu
Copy link

hey,
I am working on this issue
IMG_0899

Please correct me If i am doing something wrong
So, I checked the website of zulip and checked how this view button works
I started working on this issue and I have showed the message in the dialogbox so this is how it looks like .

@whodivyanshu
Copy link

So, the model this is right or should i do same like what is done in the web

@gnprice
Copy link
Member Author

gnprice commented Nov 8, 2024

Let's put the preview in the compose box, replacing the content input, just like in Zulip web.

And the text styling should be sure to be the same as it is in the message list — after all, the point of the preview is to see how your message will look if you send it. In the screenshot above, it looks like the text is smaller.

@whodivyanshu
Copy link

whodivyanshu commented Nov 13, 2024

ScreenRecording_11-14-2024.02-03-04_1.MP4

@gnprice i have done this to the text can you please check is it correct

@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Nov 13, 2024

Please post a screenshot where the message uses some Zulip Markdown features, like:

*italic*
**bold**
```
code block
```
```spoiler 
testing
```
[image2.jpg](/user_uploads/2/5b/4T9c_99X3W2IYB62fKnIzyvk/image2.jpg) 

This feature will be complex to implement. It will require some work toward #488, at least to address the fact that the image-preview widget currently depends on a Message object (for the lightbox), and we don't have a Message object in this context. I think this issue isn't a great fit for a new contributor, to be honest.

@whodivyanshu

This comment was marked as off-topic.

@gnprice
Copy link
Member Author

gnprice commented Nov 13, 2024

@whodivyanshu It doesn't sound like you're approaching this in a way that's going to work. A successful approach to this issue isn't going to involve re-implementing Zulip's message content features one by one.

If you want to share more details of what you're doing, please start a PR thread or a chat thread in #mobile-dev-help. Let's keep this issue thread clear so it's readable for discussion of the issue itself.

@PIG208 PIG208 linked a pull request Nov 14, 2024 that will close this issue
@gnprice gnprice modified the milestones: M6: Post-launch, M7: Future Nov 21, 2024
@gnprice
Copy link
Member Author

gnprice commented Nov 21, 2024

Oh hey, it turns out we already had an issue for this:

I'll close this thread in favor of that one, and consolidate to there the useful bits of information from this thread.

@gnprice gnprice closed this as not planned Won't fix, can't repro, duplicate, stale Nov 21, 2024
@gnprice gnprice changed the title Previews when composing a message Previews when composing a message (dupe) Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose Compose box, autocomplete, attaching files/images duplicate
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants