added the preview content functionality for the compose box #1061
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PIG208
reviewed
Nov 14, 2024
lib/widgets/compose_box.dart
Outdated
| InlineSpan _buildStyledText(String text, BuildContext context) { | ||
| final boldPattern = RegExp(r'\*\*(.*?)\*\*'); | ||
| final italicPattern = RegExp(r'\*(.*?)\*'); | ||
| final codePattern = RegExp(r'```(.*?)```', dotAll: true); // Match ```code``` |
There was a problem hiding this comment.
Hmm. I don't think parsing the message content with regular expressions is the right approach. This will eventually leads to the complexity of re-implementing Zulip's markdown processor from scratch, if we want to have full support of all message content features. A correct implementation should use the render-message endpoint, and reuse the content parser.
|
As discussed above, this approach isn't going to work, so I'll close this PR. @whodivyanshu if you'd like to contribute to Zulip, I recommend finding a more approachable issue to work on. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.