Skip to content

Order Unicode emoji options the same way as web #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnprice opened this issue Dec 23, 2024 · 0 comments
Open

Order Unicode emoji options the same way as web #1201

gnprice opened this issue Dec 23, 2024 · 0 comments
Labels
a-api Implementing specific parts of the Zulip server API

Comments

@gnprice
Copy link
Member

gnprice commented Dec 23, 2024

In the emoji picker and in emoji autocomplete, Zulip web offers the Unicode emoji in a particular, logical, order. We should match that order.

Implementation

The way this works on web is that a data file groups the emoji by category and has an order within each of the categories, and the code has a list of categories. The data file, like that code, is built into the web client.

See the web implementation in emoji_picker.rebuild_catalog, composebox_typeahead.update_emoji_data which receives its output, and emoji.update_emojis which builds part of its input:
https://github.com/zulip/zulip/blob/0f59e2e78/web/src/emoji_picker.ts#L132-L185
https://github.com/zulip/zulip/blob/0f59e2e78/web/src/composebox_typeahead.ts#L138-L163
https://github.com/zulip/zulip/blob/0f59e2e78/web/src/emoji.ts#L232-L278

So to match that behavior, we'll need that data from the server. This will mean a change to the Zulip server API: there's already an emoji data file we fetch from the server, and it should gain this information. See our [fetchServerEmojiData].

@gnprice gnprice added this to the M6: Post-launch milestone Dec 23, 2024
gnprice added a commit that referenced this issue Dec 23, 2024
I've just filed this TODO item as #1201, so link there.
@gnprice gnprice added the a-api Implementing specific parts of the Zulip server API label Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API
Projects
Status: No status
Development

No branches or pull requests

1 participant