Skip to content

msglist: In "All messages", content and the scroll-to-bottom button render in iOS bottom inset #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisbobbe opened this issue Aug 11, 2023 · 1 comment · Fixed by #379
Labels
a-iOS Issues specific to iOS, or requiring iOS-specific work a-msglist The message-list screen, except what's label:a-content

Comments

@chrisbobbe
Copy link
Collaborator

At bottom Not at bottom (scroll button visible)
665ADFE7-9A05-4BE5-8DF3-66F04CFEAF56 77BCA164-EC03-4D6A-9EF5-2F61CB456DB3

Hmm, iOS's "screenshot" feature doesn't actually show the rounded hardware corners, but those can be imagined, or I could use macOS's screenshot feature to capture an iOS device simulator.

But also, from reading code, one can see that the bottom inset isn't accounted for in the all-messages view.

This will be naturally solved if we put some surface down there that pads the bottom inset, with the message list abutting that surface in the y-direction. That surface is likely to be the bottom nav bar in Vlad's design, I think.

@chrisbobbe chrisbobbe added a-msglist The message-list screen, except what's label:a-content a-iOS Issues specific to iOS, or requiring iOS-specific work labels Aug 11, 2023
@gnprice gnprice added this to the Alpha milestone Aug 14, 2023
@gnprice
Copy link
Member

gnprice commented Aug 14, 2023

Hmm, good catch, thanks!

I initially applied the Alpha milestone, but then thought again about the fact that it only applies in narrows that don't show a compose box. I think that makes this bug tolerable for an alpha, so I'll move it to the Beta milestone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-iOS Issues specific to iOS, or requiring iOS-specific work a-msglist The message-list screen, except what's label:a-content
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants