-
Notifications
You must be signed in to change notification settings - Fork 309
Autocomplete for topic to send to #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I've reviewed this task, and I believe it's one step up compared to my previous contributions. I am confident I can tackle it effectively.
I am keen to take on this task and intend to start by creating an initial prototype before requesting formal assignment. |
@Khader-1 Sounds good! Please go ahead. |
This data structure is likely a thing that will end up being used for other things. (It can take like 0.5s to get a response in a stream with thousands of topics). |
Thanks Tim! For a solution for this issue, I think I'd be happy with a version where the list of topics for a given stream is only cached for the lifetime of a given autocomplete interaction — that is, for the lifetime of a given topic input field. In particular that avoids most of the complexity of maintaining the data structure, because it's OK if it doesn't stay accurately in sync in subtle edge cases (and really it's 95% OK if it doesn't get updated at all), because not many changes will happen during its lifetime. The main cost is that 0.5s lag to get the list of topics. But we'd have that anyway the first time a user goes to compose in a given stream, so I'm not sure there's a huge difference between that and every time. Hmm, though I guess one benefit of keeping it around longer is that we could be more eager about fetching it — like when you view a given stream narrow, rather than when you start composing. Then you might rarely actually see the 0.5s latency. In any case: for when we do tackle this data structure (as part of this issue or later), see also So I'd want to factor that out into a somewhat more generic list-of-recent-conversations data structure, with |
We should offer autocompletion in the topic input of the compose box. (When that topic input exists, i.e. for interleaved narrows.)
This is a step on the way to:
and an element we'll almost surely want in any UX solution we choose there.
Not to be confused with autocomplete for mentioning a topic inside the content of a message:
The text was updated successfully, but these errors were encountered: