Skip to content

msglist: Area around mark-as-read button should be transparent (to colorScheme.background), not white #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrisbobbe opened this issue Nov 20, 2023 · 1 comment · Fixed by #402
Closed

msglist: Area around mark-as-read button should be transparent (to colorScheme.background), not white #401

chrisbobbe opened this issue Nov 20, 2023 · 1 comment · Fixed by #402
Assignees
@chrisbobbe

Comments

@chrisbobbe
Copy link
Collaborator

See this frame in the Figma: https://www.figma.com/file/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?type=design&node-id=147-9087&mode=design&t=BVHFiwepIX29vEdI-0

image
@chrisbobbe chrisbobbe self-assigned this Nov 20, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Nov 20, 2023
@chrisbobbe
msglist: Move white background color to MessageItem, from whole list
5c74a19 
This lets `colorScheme.background` (which we matched to the Figma in
21dbae1) come through in the area with the "Mark X messages as
read" button, following a Figma frame:
  https://www.figma.com/file/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=147%3A9133&mode=dev
(There's a different Figma frame that shows a stream-specific color
there; more on that in the next commit.)

The background color (`colorScheme.background`) will now also come
through in these areas:

- in the area with the "No earlier messages" text, when scrolled to
  the earliest messages
- in the new blank space we added after the most recent message,
  earlier in this series of commits.

Fixes: zulip#401
@chrisbobbe chrisbobbe mentioned this issue Nov 20, 2023
Merged
@chrisbobbe
Copy link
Collaborator Author

(ColorScheme.background is #f6f6f6, as we set it in 21dbae1.)

chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Nov 20, 2023
@chrisbobbe
msglist: Move white background color to MessageItem, from whole list
2eb94c9 
This lets `colorScheme.background` (which we matched to the Figma in
21dbae1) come through in the area with the "Mark X messages as
read" button, following a Figma frame:
  https://www.figma.com/file/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=147%3A9133&mode=dev
(There's a different Figma frame that shows a stream-specific color
there; more on that in the next commit.)

The background color (`colorScheme.background`) will now also come
through in these areas:

- in the area with the "No earlier messages" text, when scrolled to
  the earliest messages
- in the new blank space we added after the most recent message,
  earlier in this series of commits.

Fixes: zulip#401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbobbe chrisbobbe

Labels
None yet
Projects
Flutter app
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

msglist: Add end-of-feed whitespace; use background color from Figma chrisbobbe/zulip-flutter
1 participant
@chrisbobbe