Skip to content

notif: Use live value for app ID on registering APNs token #407

Closed
@gnprice

Description

@gnprice

In my draft for #321 I have a TODO like this:

      case TargetPlatform.iOS:
        const appBundleId = 'com.zulip.flutter'; // TODO find actual value live
        await registerApnsToken(connection, token: token, appid: appBundleId);

This will be just fine as long as the app ID is indeed com.zulip.flutter. That means it will basically be fine right through the beta period, until we start rolling this app out as the new version of org.zulip.Zulip (the app ID currently occupied by the zulip-mobile RN app).

The fix is easy, locally:

        final appBundleId = (await PackageInfo.fromPlatform()).packageName;

The one wrinkle is that that version breaks tests, because it's directly calling a plugin. To fix it, we'll want to indirect PackageInfo.fromPlatform through a method on ZulipBinding, like we've done for other plugins. This still isn't hard, but given the impending beta, I'm deferring it for now.

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    Status

    Done

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions