Skip to content

lightbox: Show user's avatar in the lightbox app bar #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
chrisbobbe opened this issue Mar 31, 2023 · 3 comments · Fixed by #1092
Closed

lightbox: Show user's avatar in the lightbox app bar #41

chrisbobbe opened this issue Mar 31, 2023 · 3 comments · Fixed by #1092
Assignees
Labels
a-lightbox The lightbox / image-viewer screen help wanted

Comments

@chrisbobbe
Copy link
Collaborator

In the lightbox, the RN app shows the message author's avatar along with their name in the app bar; we should do the same in the Flutter app. Like in the RN app, probably the avatar should go beside the name/date text, in the "start" direction (left in LTR).

Perhaps it should have a presence indicator (?) but that could be done in a later iteration.

@gnprice gnprice added the m-beta label May 26, 2023
@gnprice gnprice added this to the Beta milestone May 27, 2023
@gnprice gnprice added a-lightbox The lightbox / image-viewer screen and removed m-beta labels May 27, 2023
@gnprice gnprice modified the milestones: Beta 1, Beta 2 Nov 8, 2023
@gnprice gnprice modified the milestones: Beta 2, Beta 3 Nov 22, 2023
@shivanshsharma13

This comment was marked as off-topic.

shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 1, 2024
Add avatars to DM recipient headers.

Display user avatars alongside names in DM recipient headers, making conversations more visually identifiable. This matches the RN app's behavior

The changes:

- Add Avatar widgets in DM recipient headers
- Maintain consistent sizing and spacing (35px size, 8px right padding)
- Handle overflow gracefully for both avatars and names

Fixes zulip#41
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 1, 2024
Add avatars to DM recipient headers.

Display user avatars alongside names in DM recipient headers, making conversations more visually identifiable. This matches the RN app's behavior

The changes:

- Add Avatar widgets in DM recipient headers
- Maintain consistent sizing and spacing (35px size, 8px right padding)
- Handle overflow gracefully for both avatars and names

Fixes zulip#41
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 1, 2024
Add avatars to DM recipient headers.

Display user avatars alongside names in DM recipient headers, making conversations more visually identifiable. This matches the RN app's behavior

The changes:

- Add Avatar widgets in DM recipient headers
- Maintain consistent sizing and spacing (35px size, 8px right padding)
- Handle overflow gracefully for both avatars and names

Fixes zulip#41
@chrisbobbe
Copy link
Collaborator Author

That screenshot doesn't show the lightbox.

@sher999
Copy link

sher999 commented Dec 7, 2024

Tried solving this issue

code changes

title: Row(
          children: [
            Avatar(size: 32, borderRadius: 3,userId: widget.message.senderId),
            const SizedBox(width: 8),
            RichText(
              text: TextSpan(children: [
                TextSpan(
                  text: '${widget.message.senderFullName}\n',

                  // Restate default
                  style: themeData.textTheme.titleLarge!.copyWith(color: appBarForegroundColor)),
                TextSpan(
                  text: timestampText,

                  // Make smaller, like a subtitle
                  style: themeData.textTheme.titleSmall!.copyWith(color: appBarForegroundColor)),
              ])),
          ],
        ),
        bottom: widget.buildAppBarBottom(context));
Screenshot

Simulator Screenshot - iPhone 16 - 2024-12-07 at 15 26 00

shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 7, 2024
This change updates the lightbox to display the message author's avatar
alongside their name and the date in the app bar. The avatar is positioned
in the "start" direction (left for LTR layouts, right for RTL layouts) to
align with the behavior in the React Native app.

Fixes zulip#41
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 11, 2024
This change updates the lightbox to display the message author's avatar
alongside their name and the date in the app bar. The avatar is
positioned in the "start" direction (left for LTR layouts, right for
RTL layouts) to align with the behavior in the React Native app.

Fixes: zulip#41
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 13, 2024
This change updates the lightbox to display the message author's avatar
alongside their name and the date in the app bar. The avatar is
positioned in the "start" direction (left for LTR layouts, right for
RTL layouts) to align with the behavior in the React Native app.

Fixes: zulip#41
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 14, 2024
This change updates the lightbox to display the message author's avatar
alongside their name and the date in the app bar. The avatar is
positioned in the "start" direction (left for LTR layouts, right for
RTL layouts) to align with the behavior in the React Native app.

Fixes: zulip#41
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 18, 2024
This change updates the lightbox to display the message author's avatar
alongside their name and the date in the app bar. The avatar is
positioned in the "start" direction (left for LTR layouts, right for
RTL layouts) to align with the behavior in the React Native app.

Fixes: zulip#41
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 18, 2024
This change updates the lightbox to display the message author's avatar
alongside their name and the date in the app bar. The avatar is
positioned in the "start" direction (left for LTR layouts, right for
RTL layouts) to align with the behavior in the React Native app.

Fixes: zulip#41
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Dec 19, 2024
This change updates the lightbox to display the message author's avatar
alongside their name and the date in the app bar. The avatar is
positioned in the "start" direction (left for LTR layouts, right for
RTL layouts) to align with the behavior in the React Native app.

Fixes: zulip#41
shivanshsharma13 added a commit to shivanshsharma13/zulip-flutter that referenced this issue Jan 3, 2025
This change updates the lightbox to display the message author's avatar
alongside their name and the date in the app bar. The avatar is
positioned in the "start" direction (left for LTR layouts, right for
RTL layouts) to align with the behavior in the React Native app.

Fixes: zulip#41
@gnprice gnprice closed this as completed in 0b90e42 Jan 7, 2025
Gaurav-Kushwaha-1225 pushed a commit to Gaurav-Kushwaha-1225/zulip-flutter that referenced this issue Jan 8, 2025
This change updates the lightbox to display the message author's avatar
alongside their name and the date in the app bar. The avatar is
positioned in the "start" direction (left for LTR layouts, right for
RTL layouts) to align with the behavior in the React Native app.

Fixes: zulip#41
rishichirchi pushed a commit to rishichirchi/zulip-flutter that referenced this issue Feb 7, 2025
This change updates the lightbox to display the message author's avatar
alongside their name and the date in the app bar. The avatar is
positioned in the "start" direction (left for LTR layouts, right for
RTL layouts) to align with the behavior in the React Native app.

Fixes: zulip#41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-lightbox The lightbox / image-viewer screen help wanted
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants