Skip to content

AboutZulipPage: "Licenses" page broken #435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
chrisbobbe opened this issue Dec 4, 2023 · 1 comment · Fixed by #436
Closed

AboutZulipPage: "Licenses" page broken #435

chrisbobbe opened this issue Dec 4, 2023 · 1 comment · Fixed by #436
Assignees
@chrisbobbe

Comments

@chrisbobbe
Copy link
Collaborator

D16E5638-1896-4FB7-9D68-A5098408F5D3
@chrisbobbe chrisbobbe self-assigned this Dec 4, 2023
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Dec 4, 2023
@chrisbobbe
assets: Add Noto Color Emoji back again, for use on Android
c2c3db3 
Downloaded from:
  https://github.com/googlefonts/noto-emoji/tree/d79d23e68/fonts

We removed this in a1da95a, but we want to add it back now that
we're more confident that it will work on Android. In the time since
a1da95a, we learned that COLRv1 fonts just never work on
iOS/macOS; they aren't supported:
  flutter/flutter#134897 (comment)

So, when trying to explain why this font wasn't working in a test on
my iPhone, it seems less necessary to consider a possible unknown
factor that might affect some Android installs too. It was likely
explained just by the fact that the format doesn't have iOS support.

This fixes zulip#435, where the "Licenses" page was broken because we
forgot to remove its reference to the Noto Color Emoji license that
we removed in a1da95a.

Fixes: zulip#404
Fixes: zulip#435
chrisbobbe added a commit to chrisbobbe/zulip-flutter that referenced this issue Dec 4, 2023
@chrisbobbe
assets: Add Noto Color Emoji back again, for use on Android
2447ec3 
Downloaded from:
  https://github.com/googlefonts/noto-emoji/tree/d79d23e68/fonts

We removed this in a1da95a, but we want to add it back now that
we're more confident that it will work on Android. In the time since
a1da95a, we learned that COLRv1 fonts just never work on
iOS/macOS; they aren't supported:
  flutter/flutter#134897 (comment)

So, when trying to explain why this font wasn't working in a test on
my iPhone, it seems less necessary to consider a possible unknown
factor that might affect some Android installs too. It was likely
explained just by the fact that the format doesn't have iOS support.

This fixes zulip#435, where the "Licenses" page was broken because we
forgot to remove its reference to the Noto Color Emoji license that
we removed in a1da95a.

Fixes: zulip#404
Fixes: zulip#435
@chrisbobbe chrisbobbe mentioned this issue Dec 4, 2023
Merged
@gnprice
Copy link
Member

gnprice commented Dec 4, 2023

Oops, good catch. Guess we need to take care of removing from this list when we remove a third-party asset, as well as adding when we add one.

(Though in this case we actually want to add the asset back again anyway, as I see you have a PR to do.)

@gnprice gnprice closed this as completed in 341f2af Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisbobbe chrisbobbe

Labels
None yet
Projects
Flutter app
Status: Done
Milestone
No milestone
2 participants
@gnprice @chrisbobbe