Skip to content

Track realm settings #668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnprice opened this issue May 13, 2024 · 1 comment
Open

Track realm settings #668

gnprice opened this issue May 13, 2024 · 1 comment
Labels
a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.) a-settings UI to show and edit settings and do admin tasks

Comments

@gnprice
Copy link
Member

gnprice commented May 13, 2024

Zulip has a long list of realm settings. Many of them are relevant to the mobile app. This issue is for beginning to track a few of them; once we do that, it'll be easy to add individual settings when they come up.

The settings are documented as part of the main event that updates them:
https://zulip.com/api/get-events#realm-update_dict
Note there's a different event that can also update them:
https://zulip.com/api/get-events#realm-update
and so we need to support both.

The settings are also present on the initial snapshot, generally with a name realm_foo for a realm setting named foo.

For a model for how this can work, see our handling of user settings, in particular UserSettingName. The goal is to set up a system where adding any one new setting involves adding only a small number of lines of code in a small number of places. The PR for this issue should end with a commit that demonstrates that, by adding one more setting, just like #261 did for user settings with its last commit 4bcbffd52.

@gnprice gnprice added a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.) a-settings UI to show and edit settings and do admin tasks labels May 13, 2024
@gnprice gnprice added this to the Beta 3: Summer 2024 milestone May 13, 2024
@gnprice
Copy link
Member Author

gnprice commented Jul 27, 2024

Pushing this back to the post-launch milestone — we can pull it forward again when we identify a specific feature that depends on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-api Implementing specific parts of the Zulip server API a-model Implementing our data model (PerAccountStore, etc.) a-settings UI to show and edit settings and do admin tasks
Projects
Status: No status
Development

No branches or pull requests

1 participant