-
Notifications
You must be signed in to change notification settings - Fork 309
Track all valid Zulip emoji #669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
This completes the data we'll need for use in zulip#669, which in turn will let us offer an emoji picker for reactions and for use inside message content. The doc on fetchEmojiData is based on a comment at the corresponding code in the legacy zulip-mobile app, in src/events/eventActions.js .
With #976 (which I've just sent) we'll have all the data. The remaining data-model work I want to do before declaring victory here is to handle searching through the list of emoji to produce the data we'd use for an emoji-picker UI (for #388 or #670). Between that and the logic we already have (and in #967 refactored onto EmojiStore) for looking up an individual emoji to decide how to display it, we'll be covering all the ways the app needs to use emoji data, which is the key criterion for being confident that our model has all the features it needs. |
This completes the data we'll need for use in zulip#669, which in turn will let us offer an emoji picker for reactions and for use inside message content. The doc on fetchEmojiData is based on a comment at the corresponding code in the legacy zulip-mobile app, in src/events/eventActions.js .
This completes the data we'll need for use in zulip#669, which in turn will let us offer an emoji picker for reactions and for use inside message content. The doc on fetchEmojiData is based on a comment at the corresponding code in the legacy zulip-mobile app, in src/events/eventActions.js .
This leaves the emojiDisplay field of these objects untested. I skipped that because it seems like pretty boring low-risk code, just invoking emojiDisplayFor. (And emojiDisplayFor has its own tests.) But included a TODO comment for completeness in thinking about what logic there is to test here. Fixes: zulip#669
This is a prerequisite for:
In order to offer the user a UI to choose an emoji from the emoji Zulip knows about, we'll need to know what emoji those are and what Zulip calls them.
Zulip has a particular data model for identifying emoji, which is an underdocumented part of the Zulip API. For an introduction, see
reaction_type
here:https://zulip.com/api/add-reaction#parameter-reaction_type
and the two companion fields
emoji_code
andemoji_name
. (The same emoji model is used for reactions as for emoji in messages.)Then see zulip-mobile's
src/emoji/data.js
, which tracks this model.A good implementation of this issue will:
The text was updated successfully, but these errors were encountered: