Skip to content

Redesign for @-mention autocomplete items #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnprice opened this issue Aug 23, 2024 · 3 comments · Fixed by #995
Closed

Redesign for @-mention autocomplete items #913

gnprice opened this issue Aug 23, 2024 · 3 comments · Fixed by #995
Assignees
Labels
a-compose Compose box, autocomplete, attaching files/images a-design Visual and UX design

Comments

@gnprice
Copy link
Member

gnprice commented Aug 23, 2024

From @terpimost we have a spiffy new design for how the result items in @-mention autocomplete should look:
image

Detailed specs are in Figma:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3859-3131&m=dev

This issue is only about the design for each item. Out of scope is how the whole list of autocomplete results is presented:

@gnprice gnprice added a-compose Compose box, autocomplete, attaching files/images a-design Visual and UX design labels Aug 23, 2024
@gnprice gnprice added this to the Launch milestone Aug 23, 2024
@fombalang
Copy link
Contributor

Hello everyone.
I started working on this issue

Before
before

After
after

I had some worries I would like to have clarified please.
The design file says the color token for the metaData (email) field is called contextMenuItemMeta, but there is no contextMenuItemMeta token in the DesignVariables so I used the designVariables.labelEdited color token instead.

Also, according to the design, the metaData can be constructed from various user information, please I would like to find out what variables exactly will be used for the metaData field? At the moment I am using the users[userId]!.email variable, which seems to be the user's Zulip specific email, not sure if that works?

Any feedback would be much appreciated, thank you.
@gnprice @chrisbobbe

@gnprice
Copy link
Member Author

gnprice commented Oct 9, 2024

I made a chat thread to answer those questions:
https://chat.zulip.org/#narrow/stream/516-mobile-dev-help/topic/redesign.20for.20.40-mention.20autocomplete.20items/near/1958826

For future questions like these — questions about how a feature should work, or about how to develop a change — I recommend asking in a public channel in chat.zulip.org. That'll typically get you a faster response, and the discussion can be helpful for others reading it too. #mobile-dev-help is a good choice any time you're not sure which channel to use.

@fombalang
Copy link
Contributor

I made a chat thread to answer those questions: https://chat.zulip.org/#narrow/stream/516-mobile-dev-help/topic/redesign.20for.20.40-mention.20autocomplete.20items/near/1958826

For future questions like these — questions about how a feature should work, or about how to develop a change — I recommend asking in a public channel in chat.zulip.org. That'll typically get you a faster response, and the discussion can be helpful for others reading it too. #mobile-dev-help is a good choice any time you're not sure which channel to use.

Okay, thank you. Understood

fombalang added a commit to fombalang/zulip-flutter that referenced this issue Oct 11, 2024
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Updated autocomplete tests

Fixes: zulip#913
fombalang added a commit to fombalang/zulip-flutter that referenced this issue Oct 11, 2024
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Updated autocomplete tests.

Fixes: zulip#913
fombalang added a commit to fombalang/zulip-flutter that referenced this issue Oct 15, 2024
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Updated autocomplete tests.

Fixes: zulip#913
fombalang added a commit to fombalang/zulip-flutter that referenced this issue Oct 29, 2024
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Updated autocomplete tests.
Relaxed avatar finder requirements so
it accepts avatar URLs with size identifiers too.

Fixes: zulip#913
fombalang added a commit to fombalang/zulip-flutter that referenced this issue Oct 31, 2024
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Updated autocomplete tests.
Relaxed avatar finder requirements so
it accepts avatar URLs with size identifiers too.

Fixes: zulip#913
fombalang added a commit to fombalang/zulip-flutter that referenced this issue Nov 1, 2024
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Updated autocomplete tests.
Relaxed avatar finder requirements so
it accepts avatar URLs with size identifiers too.

Fixes: zulip#913
fombalang added a commit to fombalang/zulip-flutter that referenced this issue Nov 4, 2024
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Updated autocomplete tests.
Relaxed avatar finder requirements so
it accepts avatar URLs with size identifiers too.

Fixes: zulip#913
fombalang added a commit to fombalang/zulip-flutter that referenced this issue Nov 9, 2024
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Updated autocomplete tests.

Fixes: zulip#913
fombalang added a commit to fombalang/zulip-flutter that referenced this issue Nov 12, 2024
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Updated autocomplete tests.

Fixes: zulip#913
fombalang added a commit to fombalang/zulip-flutter that referenced this issue Nov 12, 2024
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Updated autocomplete tests.

Fixes: zulip#913
fombalang added a commit to fombalang/zulip-flutter that referenced this issue Nov 26, 2024
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Updated autocomplete tests.

Fixes: zulip#913
gnprice pushed a commit to fombalang/zulip-flutter that referenced this issue Nov 26, 2024
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Updated autocomplete tests.

[greg: rebased atop _EmojiAutocompleteItem; added TODO items there]

Fixes: zulip#913
fombalang added a commit to fombalang/zulip-flutter that referenced this issue Jan 12, 2025
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Updated autocomplete tests.
Checks delivery email is visible only when its not null,
and the server generated fake email isn't shown.
Also fixes minor bug in example_data.dart which
causes delivery email to always be shown in tests.

Fixes: zulip#913
fombalang added a commit to fombalang/zulip-flutter that referenced this issue Jan 12, 2025
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Updated autocomplete tests.
Checks delivery email is visible only when its not null,
and the server generated fake email isn't shown.
Also fixes minor bug in example_data.dart which
causes delivery email to always be shown in tests.

Fixes: zulip#913
@gnprice gnprice modified the milestones: M5: Launch, M5-a: Server 10 Jan 14, 2025
PIG208 pushed a commit to PIG208/zulip-flutter that referenced this issue Feb 28, 2025
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Updated autocomplete tests.
Checks delivery email is visible only when its not null,
and the server generated fake email isn't shown.
Also fixes minor bug in example_data.dart which
causes delivery email to always be shown in tests.

Fixes: zulip#913
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 1, 2025
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Fixes: zulip#913

Co-authored-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
PIG208 added a commit to PIG208/zulip-flutter that referenced this issue Mar 1, 2025
Implemented new design for @-mention autocomplete items.
Added new `contextMenuItemLabel` and `contextMenuItemMeta`
color variables to `designVariables` class.

Fixes: zulip#913

Co-authored-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
@gnprice gnprice closed this as completed in 61b64cd Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-compose Compose box, autocomplete, attaching files/images a-design Visual and UX design
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants