-
Notifications
You must be signed in to change notification settings - Fork 309
Redesign for @-mention autocomplete items #913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hello everyone. I had some worries I would like to have clarified please. Also, according to the design, the metaData can be constructed from various user information, please I would like to find out what variables exactly will be used for the metaData field? At the moment I am using the Any feedback would be much appreciated, thank you. |
I made a chat thread to answer those questions: For future questions like these — questions about how a feature should work, or about how to develop a change — I recommend asking in a public channel in chat.zulip.org. That'll typically get you a faster response, and the discussion can be helpful for others reading it too. #mobile-dev-help is a good choice any time you're not sure which channel to use. |
Okay, thank you. Understood |
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Updated autocomplete tests Fixes: zulip#913
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Updated autocomplete tests. Fixes: zulip#913
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Updated autocomplete tests. Fixes: zulip#913
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Updated autocomplete tests. Relaxed avatar finder requirements so it accepts avatar URLs with size identifiers too. Fixes: zulip#913
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Updated autocomplete tests. Relaxed avatar finder requirements so it accepts avatar URLs with size identifiers too. Fixes: zulip#913
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Updated autocomplete tests. Relaxed avatar finder requirements so it accepts avatar URLs with size identifiers too. Fixes: zulip#913
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Updated autocomplete tests. Relaxed avatar finder requirements so it accepts avatar URLs with size identifiers too. Fixes: zulip#913
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Updated autocomplete tests. Fixes: zulip#913
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Updated autocomplete tests. Fixes: zulip#913
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Updated autocomplete tests. Fixes: zulip#913
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Updated autocomplete tests. Fixes: zulip#913
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Updated autocomplete tests. [greg: rebased atop _EmojiAutocompleteItem; added TODO items there] Fixes: zulip#913
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Updated autocomplete tests. Checks delivery email is visible only when its not null, and the server generated fake email isn't shown. Also fixes minor bug in example_data.dart which causes delivery email to always be shown in tests. Fixes: zulip#913
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Updated autocomplete tests. Checks delivery email is visible only when its not null, and the server generated fake email isn't shown. Also fixes minor bug in example_data.dart which causes delivery email to always be shown in tests. Fixes: zulip#913
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Updated autocomplete tests. Checks delivery email is visible only when its not null, and the server generated fake email isn't shown. Also fixes minor bug in example_data.dart which causes delivery email to always be shown in tests. Fixes: zulip#913
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Fixes: zulip#913 Co-authored-by: Zixuan James Li <[email protected]> Signed-off-by: Zixuan James Li <[email protected]>
Implemented new design for @-mention autocomplete items. Added new `contextMenuItemLabel` and `contextMenuItemMeta` color variables to `designVariables` class. Fixes: zulip#913 Co-authored-by: Zixuan James Li <[email protected]> Signed-off-by: Zixuan James Li <[email protected]>
From @terpimost we have a spiffy new design for how the result items in @-mention autocomplete should look:

Detailed specs are in Figma:
https://www.figma.com/design/1JTNtYo9memgW7vV6d0ygq/Zulip-Mobile?node-id=3859-3131&m=dev
This issue is only about the design for each item. Out of scope is how the whole list of autocomplete results is presented:
The text was updated successfully, but these errors were encountered: