Skip to content

Visual glitches when scrolling on Fairphone 3+ #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
j-maas opened this issue Sep 13, 2024 · 12 comments
Closed

Visual glitches when scrolling on Fairphone 3+ #941

j-maas opened this issue Sep 13, 2024 · 12 comments
Labels
a-Android Issues specific to Android, or requiring Android-specific work

Comments

@j-maas
Copy link

j-maas commented Sep 13, 2024

I'm using Android on a Fairphone 3+. When I scroll in the Zulip Beta v0.0.19, I see some weird artifacts.

It doesn't seem to impact functionality, it's just visually annoying.

Curiously, when I try to record my screen on the phone, the glitches don't appear. As soon as the screen recording is stopped, they appear again when scrolling.

I was however able to capture some screenshots of what it looks like. These are only visible for a frame each, but while scrolling there are a lot of such glitches.

Normal Scrolling Scrolling more
Screenshot_20240913-210444.png Screenshot_20240913-210446.png Screenshot_20240913-210450.png
@gnprice
Copy link
Member

gnprice commented Sep 13, 2024

Interesting, thanks for the report! I don't think we've seen a symptom like that before in this app.

Given these symptoms, I think the issue has to be either in the Flutter engine, or your device's graphics drivers (or I guess possibly the graphics hardware). Flutter is in the late stages of a rewrite of their rendering engine, called Impeller; Impeller is currently in beta on Android, and we're using it in our beta. Being in beta means Impeller still has more bugs than it will when stable, and also that its authors are still busy discovering bugs in a wide variety of devices' graphics drivers, and adding workarounds for those.

Looking in the upstream tracker, here's one open issue with a similar flavor:

I think the Flutter engine developers will probably be able to resolve this issue pretty quickly once they can reproduce it. I'll file an issue upstream and see what further information they ask for.

@gnprice
Copy link
Member

gnprice commented Sep 13, 2024

Do you happen to have the Android developer tools set up on your machine?

If so, then one thing you can do that's very likely to be helpful is to get via adb logcat the logs that are emitted while reproducing the issue. Some details here on how to conveniently use adb logcat:
https://chat.zulip.org/#narrow/stream/243-mobile-team/topic/adb.20logcat/near/1929345

(If not, though, don't worry about it.)

@gnprice
Copy link
Member

gnprice commented Sep 13, 2024

@gnprice gnprice added the a-Android Issues specific to Android, or requiring Android-specific work label Sep 13, 2024
@gnprice gnprice added this to the Launch milestone Sep 13, 2024
@gnprice gnprice changed the title Visual glitches when scrolling Visual glitches when scrolling on Fairphone 3+ Sep 13, 2024
@gnprice
Copy link
Member

gnprice commented Oct 29, 2024

That upstream issue was closed today, with a change in the Flutter engine so that Flutter will fall back to an older graphics system when it sees the GPU that's found in that device. That should resolve this problem.

Thanks again @j-maas for the report!

Closing this issue because it's fixed upstream and I expect we'll update to a Flutter with the fix before our next beta release. (Also being closed means I'll naturally look back at it when preparing the next release, which will give me a prompt to confirm that we did update.)

@gnprice
Copy link
Member

gnprice commented Nov 13, 2024

it's fixed upstream and I expect we'll update to a Flutter with the fix before our next beta release

FTR, that update happened in 163ea28 / #1057.

@gnprice
Copy link
Member

gnprice commented Nov 14, 2024

And today's beta release v0.0.21 has that update. @j-maas please try it out when convenient, and let us know whether that indeed fixes the problem. Thanks again for the report!

@j-maas
Copy link
Author

j-maas commented Nov 14, 2024

I'm on 0.0.20 (I don't yet see the update in the PlayStore), but the glitch is already gone. Only the frame rate seems to be a bit reduced. But it's totally usable.

@gnprice
Copy link
Member

gnprice commented Nov 15, 2024

Huh! Thanks for the update.

The upstream change that was aimed at fixing this happened in flutter/engine@999797a2f690, which was pulled in by flutter/flutter@4731859, which in turn only entered our tree in the commit I mentioned above. We released 0.0.20 a few weeks before that upstream change; it used Flutter 3.26.0-1.0.pre.249, aka flutter/flutter@ead6b0d.

So I guess some earlier change already fixed the glitch. The behavior may be different again with 0.0.21, though — that one should disable Flutter's use of its Vulcan graphics backend on your GPU, falling back to GLES. I'm therefore curious how 0.0.21 goes too.

@gnprice
Copy link
Member

gnprice commented Nov 15, 2024

(I think 0.0.21 became available for you about a half-hour after your comment above, from the timestamps I see in the Play Console. It takes a bit for them to review it, even for apps in beta channels.)

@j-maas
Copy link
Author

j-maas commented Nov 16, 2024

I just noticed that it's glitch-free and smooth. So I checked the version and it's v0.0.21!

It's flawless now. Thanks for taking the time to explain everything to me and keeping me updated!

1 similar comment
@j-maas

This comment was marked as duplicate.

@gnprice
Copy link
Member

gnprice commented Nov 20, 2024

Great, glad to hear it. Thanks for the update (and the original report)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a-Android Issues specific to Android, or requiring Android-specific work
Projects
Status: Done
Development

No branches or pull requests

2 participants