content: Handle message links #1048
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnprice
reviewed
Nov 6, 2024
There was a problem hiding this comment.
Thanks @rajveermalviya for the rapid implementation! Comments below.
test/model/content_test.dart
Outdated
| const LinkNode(url: '/#narrow/stream/243-mobile-team/topic/zulip-flutter', | ||
| nodes: [TextNode('#mobile-team > zulip-flutter')])); | ||
|
|
||
| testParseInline('parse #-mention of message', |
There was a problem hiding this comment.
Let's use ContentExample for this, following the comment above:
void main() {
// When writing test cases in this file:
//
// * Prefer to add a [ContentExample] static and use [testParseExample].
// Then add one line of code to `test/widgets/content_test.dart`,
// calling `testContentSmoke`, for a widgets test on the same example.(We can skip the part about a widgets test, since the parsed result here is no different from what we get with existing links.)
lib/model/content.dart
Outdated
Comment on lines
858
to
860
| || (className == 'stream-topic' | ||
| || className == 'stream' | ||
| || className == 'message-link'))) { |
There was a problem hiding this comment.
nit:
Suggested change
| || (className == 'stream-topic' | |
| || className == 'stream' | |
| || className == 'message-link'))) { | |
| || className == 'stream-topic' | |
| || className == 'stream' | |
| || className == 'message-link')) { |
(I think the extra parens are a legacy of how the logic used to be more complicated with classes; introduced in 3cd84bb, simplified in 4c94547 but could have been simplified a bit further.)
gnprice
added
the
integration review
rajveermalviya
force-pushed
the
pr-content-handle-message-links
branch
from
247f6d5 to
921eacd
Compare
|
Thanks for the review @gnprice! Pushed a new revision — PTAL. |
|
Thanks! Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1046