Skip to content

Support adding arbitrary reactions #1103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 11, 2024
Merged

Support adding arbitrary reactions #1103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a286f7d
icons: Update chevron_right icon
rajveermalviya Dec 9, 2024
c3d38c3
action_sheet: Support reacting with popular emojis
rajveermalviya Dec 4, 2024
bc1cfb5
reactions: Support adding arbitrary reactions
rajveermalviya Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified assets/icons/ZulipIcons.ttf
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions assets/icons/chevron_right.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
20 changes: 20 additions & 0 deletions assets/l10n/app_en.arb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,10 @@
"@dialogContinue": {
"description": "Button label in dialogs to proceed."
},
"dialogClose": "Close",
"@dialogClose": {
"description": "Button label in dialogs to close."
},
"errorDialogContinue": "OK",
"@errorDialogContinue": {
"description": "Button label in error dialogs to acknowledge the error and close the dialog."
Expand Down Expand Up @@ -660,5 +664,21 @@
"errorNotificationOpenAccountMissing": "The account associated with this notification no longer exists.",
"@errorNotificationOpenAccountMissing": {
"description": "Error message when the account associated with the notification is not found"
},
"errorReactionAddingFailedTitle": "Adding reaction failed",
"@errorReactionAddingFailedTitle": {
"description": "Error title when adding a message reaction fails"
},
"errorReactionRemovingFailedTitle": "Removing reaction failed",
"@errorReactionRemovingFailedTitle": {
"description": "Error title when removing a message reaction fails"
},
"emojiReactionsMore": "more",
"@emojiReactionsMore": {
"description": "Label for a button opening the emoji picker."
},
"emojiPickerSearchEmoji": "Search emoji",
"@emojiPickerSearchEmoji": {
"description": "Hint text for the emoji picker search text field."
}
}
30 changes: 30 additions & 0 deletions lib/generated/l10n/zulip_localizations.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,12 @@ abstract class ZulipLocalizations {
/// **'Continue'**
String get dialogContinue;

/// Button label in dialogs to close.
///
/// In en, this message translates to:
/// **'Close'**
String get dialogClose;

/// Button label in error dialogs to acknowledge the error and close the dialog.
///
/// In en, this message translates to:
Expand Down Expand Up @@ -984,6 +990,30 @@ abstract class ZulipLocalizations {
/// In en, this message translates to:
/// **'The account associated with this notification no longer exists.'**
String get errorNotificationOpenAccountMissing;

/// Error title when adding a message reaction fails
///
/// In en, this message translates to:
/// **'Adding reaction failed'**
String get errorReactionAddingFailedTitle;

/// Error title when removing a message reaction fails
///
/// In en, this message translates to:
/// **'Removing reaction failed'**
String get errorReactionRemovingFailedTitle;

/// Label for a button opening the emoji picker.
///
/// In en, this message translates to:
/// **'more'**
String get emojiReactionsMore;

/// Hint text for the emoji picker search text field.
///
/// In en, this message translates to:
/// **'Search emoji'**
String get emojiPickerSearchEmoji;
}

class _ZulipLocalizationsDelegate extends LocalizationsDelegate<ZulipLocalizations> {
Expand Down
15 changes: 15 additions & 0 deletions lib/generated/l10n/zulip_localizations_ar.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,9 @@ class ZulipLocalizationsAr extends ZulipLocalizations {
@override
String get dialogContinue => 'Continue';

@override
String get dialogClose => 'Close';

@override
String get errorDialogContinue => 'OK';

Expand Down Expand Up @@ -522,4 +525,16 @@ class ZulipLocalizationsAr extends ZulipLocalizations {

@override
String get errorNotificationOpenAccountMissing => 'The account associated with this notification no longer exists.';

@override
String get errorReactionAddingFailedTitle => 'Adding reaction failed';

@override
String get errorReactionRemovingFailedTitle => 'Removing reaction failed';

@override
String get emojiReactionsMore => 'more';

@override
String get emojiPickerSearchEmoji => 'Search emoji';
}
15 changes: 15 additions & 0 deletions lib/generated/l10n/zulip_localizations_en.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,9 @@ class ZulipLocalizationsEn extends ZulipLocalizations {
@override
String get dialogContinue => 'Continue';

@override
String get dialogClose => 'Close';

@override
String get errorDialogContinue => 'OK';

Expand Down Expand Up @@ -522,4 +525,16 @@ class ZulipLocalizationsEn extends ZulipLocalizations {

@override
String get errorNotificationOpenAccountMissing => 'The account associated with this notification no longer exists.';

@override
String get errorReactionAddingFailedTitle => 'Adding reaction failed';

@override
String get errorReactionRemovingFailedTitle => 'Removing reaction failed';

@override
String get emojiReactionsMore => 'more';

@override
String get emojiPickerSearchEmoji => 'Search emoji';
}
15 changes: 15 additions & 0 deletions lib/generated/l10n/zulip_localizations_fr.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,9 @@ class ZulipLocalizationsFr extends ZulipLocalizations {
@override
String get dialogContinue => 'Continue';

@override
String get dialogClose => 'Close';

@override
String get errorDialogContinue => 'OK';

Expand Down Expand Up @@ -522,4 +525,16 @@ class ZulipLocalizationsFr extends ZulipLocalizations {

@override
String get errorNotificationOpenAccountMissing => 'The account associated with this notification no longer exists.';

@override
String get errorReactionAddingFailedTitle => 'Adding reaction failed';

@override
String get errorReactionRemovingFailedTitle => 'Removing reaction failed';

@override
String get emojiReactionsMore => 'more';

@override
String get emojiPickerSearchEmoji => 'Search emoji';
}
15 changes: 15 additions & 0 deletions lib/generated/l10n/zulip_localizations_ja.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,9 @@ class ZulipLocalizationsJa extends ZulipLocalizations {
@override
String get dialogContinue => 'Continue';

@override
String get dialogClose => 'Close';

@override
String get errorDialogContinue => 'OK';

Expand Down Expand Up @@ -522,4 +525,16 @@ class ZulipLocalizationsJa extends ZulipLocalizations {

@override
String get errorNotificationOpenAccountMissing => 'The account associated with this notification no longer exists.';

@override
String get errorReactionAddingFailedTitle => 'Adding reaction failed';

@override
String get errorReactionRemovingFailedTitle => 'Removing reaction failed';

@override
String get emojiReactionsMore => 'more';

@override
String get emojiPickerSearchEmoji => 'Search emoji';
}
15 changes: 15 additions & 0 deletions lib/generated/l10n/zulip_localizations_pl.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,9 @@ class ZulipLocalizationsPl extends ZulipLocalizations {
@override
String get dialogContinue => 'Kontynuuj';

@override
String get dialogClose => 'Close';

@override
String get errorDialogContinue => 'OK';

Expand Down Expand Up @@ -522,4 +525,16 @@ class ZulipLocalizationsPl extends ZulipLocalizations {

@override
String get errorNotificationOpenAccountMissing => 'Konto związane z tym powiadomieniem już nie istnieje.';

@override
String get errorReactionAddingFailedTitle => 'Adding reaction failed';

@override
String get errorReactionRemovingFailedTitle => 'Removing reaction failed';

@override
String get emojiReactionsMore => 'more';

@override
String get emojiPickerSearchEmoji => 'Search emoji';
}
15 changes: 15 additions & 0 deletions lib/generated/l10n/zulip_localizations_ru.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,6 +295,9 @@ class ZulipLocalizationsRu extends ZulipLocalizations {
@override
String get dialogContinue => 'Continue';

@override
String get dialogClose => 'Close';

@override
String get errorDialogContinue => 'OK';

Expand Down Expand Up @@ -522,4 +525,16 @@ class ZulipLocalizationsRu extends ZulipLocalizations {

@override
String get errorNotificationOpenAccountMissing => 'The account associated with this notification no longer exists.';

@override
String get errorReactionAddingFailedTitle => 'Adding reaction failed';

@override
String get errorReactionRemovingFailedTitle => 'Removing reaction failed';

@override
String get emojiReactionsMore => 'more';

@override
String get emojiPickerSearchEmoji => 'Search emoji';
}
Loading