feat: prevent typing over-long topic names

[ARYPROGRAMMER]

This PR adds the functionality mentioned in the Issue #1218

• It implements a value notifier, adds a listener and creates a function to enforce limit.
• Displays the limit alongside current characters
• Does not change any core functionality and does not break anything else

Demo Video on a real android device:

demo.mp4

[gnprice]

Thanks. Before we can review this PR, it will need (a) tests, and (b) to remove extraneous changes so that the commit is readable. See our README:
https://github.com/zulip/zulip-flutter?tab=readme-ov-file#submitting-a-pull-request

[ARYPROGRAMMER]

Thanks. Before we can review this PR, it will need (a) tests, and (b) to remove extraneous changes so that the commit is readable. See our README: https://github.com/zulip/zulip-flutter?tab=readme-ov-file#submitting-a-pull-request

surely greg, the file was auto formatted thus it happened so. For the tests, I'll just look into it and fix it

[ARYPROGRAMMER]

@gnprice lgtm now , go ahead with the review. Let me know further

[ARYPROGRAMMER]

Thanks. Before we can review this PR, it will need (a) tests, and (b) to remove extraneous changes so that the commit is readable. See our README: https://github.com/zulip/zulip-flutter?tab=readme-ov-file#submitting-a-pull-request

surely greg, the file was auto formatted thus it happened so. For the tests, I'll just look into it and fix it

hey greg any updates?

[gnprice]

This still has extraneous changes which you'll need to remove before we can review it. See the link I posted above, and see in particular the Zulip guide to clear and coherent commits which is linked from there.

There's also no need to re-ping after a day. Reviewers have weekends, and holidays, and also other work responsibilities. If it's been a week or two since you requested review and there's no reply, then it can be appropriate to bump the thread.

[chrisbobbe]

Since #1218 will make our max-length check more prominent (acting even before you tap "send"), ideally we would fix a correctness issue before implementing this. I've just filed that correctness issue as #1238.

[ARYPROGRAMMER]

let me know whether I should pull changes from #1239 and add them to this PR

[chrisbobbe]

I recommend either rebasing your PR on top of my current revision for #1239 or pausing work on it until #1239 settles.

[ARYPROGRAMMER]

I recommend either rebasing your PR on top of my current revision for #1239 or pausing work on it until #1239 settles.

I think we can wait till #1239 finishes. thanks

[ARYPROGRAMMER]

@chrisbobbe any updates on this

[chrisbobbe]

#1239 has been merged! 🎉

[ARYPROGRAMMER]

#1239 has been merged! 🎉

what changes are needed now in this? just rebase?

[ARYPROGRAMMER]

i'll jjust have to pull the new compose box and its test and add my current pr changes in it, is this correct or do we need something more?

[chrisbobbe]

You should rebase your commits on top of current main, which now includes the commits from #1239. If you need help, the best place to ask is #git help in the Zulip development community 🙂

[ARYPROGRAMMER]

You should rebase your commits on top of current main, which now includes the commits from #1239. If you need help, the best place to ask is #git help in the Zulip development community 🙂

i have made the changes required in the file but maybe i would need to open a new pr for this to get rebased safely, kindly provide suggestions. thanks

[ARYPROGRAMMER]

or if you can remove merge commits or squash everything then i think this will work. let me know further

[chrisbobbe]

If you need help, the best place to ask is #git help in the Zulip development community 🙂

There's no need to open a new PR; just force-push here: https://zulip.readthedocs.io/en/latest/git/using.html#force-push-changes-to-github-after-you-ve-altered-your-history

[ARYPROGRAMMER]

If you need help, the best place to ask is #git help in the Zulip development community 🙂

There's no need to open a new PR; just force-push here: https://zulip.readthedocs.io/en/latest/git/using.html#force-push-changes-to-github-after-you-ve-altered-your-history

i mean i already created a new pr so can we go with that, i'll have to setup this up again in local if i have to do force push

PS: since that one is closed i need to figure this out now

[ARYPROGRAMMER]

If you need help, the best place to ask is #git help in the Zulip development community 🙂

There's no need to open a new PR; just force-push here: https://zulip.readthedocs.io/en/latest/git/using.html#force-push-changes-to-github-after-you-ve-altered-your-history

having some difficulties ,check once please.

git push origin +feat/compose

I ran this. maybe still there are issues. let me know further

[chrisbobbe]

If you need help, the best place to ask is #git help in the Zulip development community 🙂

[gnprice]

Thanks @ARYPROGRAMMER for your work on this so far.

We're now focusing more strictly on launch issues until the launch is ready, and this is a post-launch issue. It doesn't seem like this PR has reached the point yet of being possible for us to review, so I'll go ahead and close it.