home: Sort leading emoji first in channel names#1234
Merged
Conversation
chrisbobbe
reviewed
Dec 30, 2024
lakshya1goel
force-pushed
the
issue1202
branch
from
6e0e1f0 to
46ac2f3
Compare
Contributor
Author
|
Hello, @chrisbobbe I have done the required changes. Please have a look and let me know if anything else is required. |
Contributor
Author
|
Hi @chrisbobbe @PIG208 |
chrisbobbe
reviewed
Jan 17, 2025
Collaborator
chrisbobbe
left a comment
chrisbobbe
left a comment
There was a problem hiding this comment.
Thanks! Small comments below.
lakshya1goel
force-pushed
the
issue1202
branch
2 times, most recently
from
6167d68 to
0c567a3
Compare
Contributor
Author
|
Thanks for the detailed review. I have made the required changes. |
Contributor
Author
|
Pushed the changes atop #1290 for the sake of CI. |
chrisbobbe
reviewed
Jan 22, 2025
Collaborator
chrisbobbe
left a comment
chrisbobbe
left a comment
There was a problem hiding this comment.
Thanks! Small comments below.
lakshya1goel
force-pushed
the
issue1202
branch
from
0c567a3 to
79e0820
Compare
Contributor
Author
|
I have updated the commit message and the description of tests. Let me know if anything else is required. |
Collaborator
|
Thanks! Marking for Greg's review. |
chrisbobbe
added
integration review
gnprice
reviewed
Jan 23, 2025
Member
gnprice
left a comment
gnprice
left a comment
There was a problem hiding this comment.
Thanks @lakshya1goel for taking care of this, and @chrisbobbe for the previous reviews!
Generally this looks good. A couple of small comments below.
lakshya1goel
force-pushed
the
issue1202
branch
from
79e0820 to
12ce869
Compare
Contributor
Author
|
Thanks for the review @gnprice , I have made the required changes, Please have a look on them. |
Member
|
Great, thanks. And yep, cutting those blank lines is the change I had in mind at #1234 (comment) . All now looks good — merging. |
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this pull request
Sep 26, 2025
The `fmt` tool from GNU coreutils is very simple, and doesn't have the needed configuration knobs to be able to handle the nested lists that we now routinely use in changelog entries; it ends up mangling them. As a result, for many recent releases I've been doing the reformatting semi-manually, in Emacs: M-q to unwrap lines (after setting the text width to 999), and then a regexp find-and-replace to turn references `zulip#1234` into `#F1234`. It seems to be somewhat annoying to get Emacs to operate within a shell pipeline. But it's less annoying for Vim; and Vim's `gq` works just as well as Emacs's M-q, given the right config. So use that.
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this pull request
Oct 16, 2025
The `fmt` tool from GNU coreutils is very simple, and doesn't have the needed configuration knobs to be able to handle the nested lists that we now routinely use in changelog entries; it ends up mangling them. As a result, for many recent releases I've been doing the reformatting semi-manually, in Emacs: M-q to unwrap lines (after setting the text width to 999), and then a regexp find-and-replace to turn references `zulip#1234` into `#F1234`. It seems to be somewhat annoying to get Emacs to operate within a shell pipeline. But it's less annoying for Vim; and Vim's `gq` works just as well as Emacs's M-q, given the right config. So use that.
gnprice
added a commit
to gnprice/zulip-flutter
that referenced
this pull request
Oct 17, 2025
The `fmt` tool from GNU coreutils is very simple, and doesn't have the needed configuration knobs to be able to handle the nested lists that we now routinely use in changelog entries; it ends up mangling them. As a result, for many recent releases I've been doing the reformatting semi-manually, in Emacs: M-q to unwrap lines (after setting the text width to 999), and then a regexp find-and-replace to turn references `zulip#1234` into `#F1234`. It seems to be somewhat annoying to get Emacs to operate within a shell pipeline. But it's less annoying for Vim; and Vim's `gq` works just as well as Emacs's M-q, given the right config. So use that.
Rofumer
pushed a commit
to Rofumer/zulip-flutter
that referenced
this pull request
Mar 24, 2026
The `fmt` tool from GNU coreutils is very simple, and doesn't have the needed configuration knobs to be able to handle the nested lists that we now routinely use in changelog entries; it ends up mangling them. As a result, for many recent releases I've been doing the reformatting semi-manually, in Emacs: M-q to unwrap lines (after setting the text width to 999), and then a regexp find-and-replace to turn references `zulip#1234` into `#F1234`. It seems to be somewhat annoying to get Emacs to operate within a shell pipeline. But it's less annoying for Vim; and Vim's `gq` works just as well as Emacs's M-q, given the right config. So use that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the channel sorting logic to ensure streams with leading emojis in their names are listed above those without emojis. The updated sorting respects pinned, muted, and unmuted streams while handling emoji precedence and maintaining alphabetical order for ties.
Fixes: #1202