Skip to content

Update container styling: added border and shadow for better UI #1295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
yashrajpu wants to merge 1 commit into from
Closed

Update container styling: added border and shadow for better UI #1295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/widgets/compose_box.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1056,7 +1056,16 @@ class _ComposeBoxContainer extends StatelessWidget {
// the message list itself
return Container(width: double.infinity,
decoration: BoxDecoration(
border: Border(top: BorderSide(color: designVariables.borderBar))),
border: Border(top: BorderSide(color: designVariables.borderBar)), boxShadow: [
BoxShadow(
color: Theme.of(context).brightness == Brightness.dark
? DesignVariables.dark.bgTopBar
: Colors.transparent, // Adjust for light theme
offset: const Offset(0, -4),
blurRadius: 16,
spreadRadius: 0,
),
],),
// TODO(#720) try a Stack for the overlaid linear progress indicator
child: Material(
color: designVariables.composeBoxBg,
Expand Down
4 changes: 2 additions & 2 deletions lib/widgets/theme.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ class DesignVariables extends ThemeExtension<DesignVariables> {
bgMenuButtonActive: Colors.black.withValues(alpha: 0.05),
bgMenuButtonSelected: Colors.white,
bgTopBar: const Color(0xfff5f5f5),
borderBar: Colors.black.withValues(alpha: 0.2),
borderBar: const Color(0x1AFFFFFF),
borderMenuButtonSelected: Colors.black.withValues(alpha: 0.2),
btnLabelAttLowIntDanger: const Color(0xffc0070a),
btnLabelAttMediumIntDanger: const Color(0xffac0508),
Expand Down Expand Up @@ -175,7 +175,7 @@ class DesignVariables extends ThemeExtension<DesignVariables> {
bgMenuButtonActive: Colors.black.withValues(alpha: 0.2),
bgMenuButtonSelected: Colors.black.withValues(alpha: 0.25),
bgTopBar: const Color(0xff242424),
borderBar: Colors.black.withValues(alpha: 0.5),
borderBar: const Color(0x1AFFFFFF),
borderMenuButtonSelected: Colors.white.withValues(alpha: 0.1),
btnLabelAttLowIntDanger: const Color(0xffff8b7c),
btnLabelAttMediumIntDanger: const Color(0xffff8b7c),
Expand Down
2 changes: 2 additions & 0 deletions test/widgets/autocomplete_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,13 +330,15 @@ void main() {
text: 'some',
selection: TextSelection(baseOffset: 1, extentOffset: 3)));
await tester.pump();
await tester.pump();
check(controller.value)
..text.equals('some')
..selection.equals(
const TextSelection(baseOffset: 1, extentOffset: 3));

await tester.tap(find.text('some topic'));
await tester.pump();
await tester.pump();
check(controller.value)
..text.equals('some topic')
..selection.equals(
Expand Down