Skip to content

deps: Upgrade Flutter to 3.29.0-1.0.pre.105 and reinstate --depth=1000 #1304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2025

Conversation

PIG208
Copy link
Member

@PIG208 PIG208 commented Jan 24, 2025

And update Flutter's supporting libraries to match.

Also fixes #1204.

@PIG208 PIG208 requested a review from chrisbobbe January 24, 2025 16:51
@PIG208 PIG208 added the maintainer review PR ready for review by Zulip maintainers label Jan 24, 2025
@chrisbobbe
Copy link
Collaborator

Great! LGTM, marking for Greg's review.

@chrisbobbe chrisbobbe requested a review from gnprice January 24, 2025 20:19
@chrisbobbe chrisbobbe assigned gnprice and unassigned chrisbobbe Jan 24, 2025
@chrisbobbe chrisbobbe added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Jan 24, 2025
And update Flutter's supporting libraries to match.
…ack later"

This reverts commit 2b99578.

Fixes: zulip#1204

Signed-off-by: Zixuan James Li <[email protected]>
@gnprice
Copy link
Member

gnprice commented Jan 27, 2025

Thanks for taking care of this! Looks good; merging.

(First, editing the PR description so it has the magic link to close the issue.)

@gnprice gnprice merged commit 7b25db0 into zulip:main Jan 27, 2025
1 check passed
@PIG208 PIG208 deleted the pr-depth branch January 27, 2025 21:00
@PIG208
Copy link
Member Author

PIG208 commented Jan 27, 2025

Oh! I thought the magical part is to have the bullets.

@gnprice
Copy link
Member

gnprice commented Feb 5, 2025

Putting an issue or PR reference in a bullet (or other form of list) has a separate magical effect 🙂 — that makes the reference get expanded out to show the title and status of the referenced issue or PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Reinstate --depth=1000 in cloning Flutter, once Flutter has a new tag
3 participants