fake_api: Prepare API exceptions conveniently, distinct from HTTP exceptions #1359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And leave a couple of TODO comments in the one test file that was accidentally preparing exceptions here that won't turn out in the intended way. The next commit will provide a clean way for these tests to do what they intend instead.
This changes the message string in a few of the call sites, where the string was already an arbitrary one rather than a realistic specific string. That's still NFC because the tests weren't depending on the specific string.
chrisbobbe
force-pushed
the
pr-fake-api-exception
branch
from
2ed83f3 to
f43d2e0
Compare
|
Thanks! LGTM, merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked atop #1355. Prompted by this review thread (thanks @chrisbobbe for the observation):
#1355 (comment)
Commit messages
a933232 fake_api [nfc]: Clarify prepared exception is at HTTP layer
And leave a couple of TODO comments in the one test file that was
accidentally preparing exceptions here that won't turn out in the
intended way. The next commit will provide a clean way for these
tests to do what they intend instead.
314ce48 fake_api: Add apiException parameter; switch to it where needed
4fa79bb fake_api [nfc]: Check for confusion in httpException use
2ed83f3 test [nfc]: Introduce eg.apiBadRequest
This changes the message string in a few of the call sites, where
the string was already an arbitrary one rather than a realistic
specific string. That's still NFC because the tests weren't
depending on the specific string.