-
Notifications
You must be signed in to change notification settings - Fork 318
test: make current time testable #1363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
DateTime.now
DateTime.now
DateTime.now
DateTime.now
Thanks! fa5dfd5 added |
I believe this is just a timezone conversion away from what we have in main. The part about replacing DateTime.now with the ZulipBinding equivalent is a nice follow-up we mentioned in 0c03009. |
So it is something we want, separately from |
I wasn't aware that this function had been added. |
DateTime.now
This PR replaces
DateTime.now
withZulipBinding.utcNow
.Also, this PR reduces some redundant arguments for current time; these arguments are not needed because we can use
withClock
for testing.