home: Tweak main-menu buttons to follow Figma #1998
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
cc @alya |
chrisbobbe
added
the
product review
chrisbobbe
force-pushed
the
pr-tweak-main-menu-buttons
branch
from
330cea5 to
1909c88
Compare
rajveermalviya
approved these changes
Nov 21, 2025
Member
rajveermalviya
left a comment
rajveermalviya
left a comment
There was a problem hiding this comment.
Thanks @chrisbobbe! LGTM, moving over to Greg's review.
rajveermalviya
added
integration review
Member
|
Thanks! Looks good; please go ahead and merge once #1997 is in. |
chrisbobbe
force-pushed
the
pr-tweak-main-menu-buttons
branch
from
1909c88 to
5b33d14
Compare
Collaborator
Author
|
(Rebased atop the current revision of #1997) |
chrisbobbe
force-pushed
the
pr-tweak-main-menu-buttons
branch
3 times, most recently
from
af2260d to
6dd3fe7
Compare
The buttons were 48px instead of 44px tall, and the label's line height was 26px instead of 23px.
chrisbobbe
force-pushed
the
pr-tweak-main-menu-buttons
branch
from
6dd3fe7 to
ab36ab6
Compare
Collaborator
Author
|
Thanks! Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stacked atop #1997.