check: Fix error condition in parsing Flutter version from pubspec #2048
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
(Ran across this when I was experimenting this morning toward #2050: I'd edited pubspec.yaml by hand and didn't bother to put a proper commit-ID comment there, and the |
rajveermalviya
approved these changes
Dec 23, 2025
Member
rajveermalviya
left a comment
rajveermalviya
left a comment
There was a problem hiding this comment.
Nice find @gnprice! LGTM, feel free to merge.
chrisbobbe
added
integration review
This is intended to check if the pattern failed to match, by checking whether the array `parsed` has zero elements. To do this, it looks at the length of the array... but then it was checking if that length, as a string, is empty. Oops. Instead, check if the length, as a number, is zero.
gnprice
force-pushed
the
pr-check-version
branch
from
e67bfb8 to
ab1bb45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to check if the pattern failed to match, by checking whether the array
parsedhas zero elements. To do this, it looks at the length of the array... but then it was checking if that length, as a string, is empty. Oops. Instead, check if the length, as a number, is zero.