Skip to content

msglist: Use directional positioning for ScrollToBottomButton #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
gnprice merged 1 commit into from
Jan 5, 2026
Merged

msglist: Use directional positioning for ScrollToBottomButton #2063

gnprice merged 1 commit into from
Jan 5, 2026

Conversation

@yash-agarwa-l
Copy link
Contributor

@yash-agarwa-l yash-agarwa-l commented Jan 3, 2026 •
edited
Loading

Previously, the ScrollToBottomButton was stuck on the right even in RTL layouts. This fixes it to work correctly in both RTL and LTR.

This addresses a issue identified by @gnprice in this comment.

Before

LTR

LTR

 RTL

RTL

After

LTR

LTR

 RTL

RTL

@yash-agarwa-l
msglist: Use directional positioning for ScrollToBottomButton
ab1f622 
Previously, the `ScrollToBottomButton` was stuck on the right even
in RTL layouts. This fixes it to work correctly in both RTL and LTR.

Fixes the issue described here:
zulip#1991 (comment)
@alya
Copy link
Collaborator

alya commented Jan 3, 2026

The "after" LTR screenshot doesn't seem to demonstrate anything?

@yash-agarwa-l yash-agarwa-l mentioned this pull request Jan 3, 2026
Merged
@yash-agarwa-l
Copy link
Contributor Author

yash-agarwa-l commented Jan 3, 2026

Thanks! That was an error, I have fixed it.

@chrisbobbe chrisbobbe self-requested a review January 5, 2026 22:56
@chrisbobbe chrisbobbe self-assigned this Jan 5, 2026
@chrisbobbe chrisbobbe added the maintainer review PR ready for review by Zulip maintainers label Jan 5, 2026
@chrisbobbe
Copy link
Collaborator

chrisbobbe commented Jan 5, 2026

Thanks, this looks great! Marking for Greg's review.

@chrisbobbe chrisbobbe requested a review from gnprice January 5, 2026 22:56
@chrisbobbe chrisbobbe assigned gnprice and unassigned chrisbobbe Jan 5, 2026
@chrisbobbe chrisbobbe added integration review Added by maintainers when PR may be ready for integration and removed maintainer review PR ready for review by Zulip maintainers labels Jan 5, 2026
@gnprice
Copy link
Member

gnprice commented Jan 5, 2026

Thanks! Looks good; merging.

@gnprice gnprice merged commit ab1f622 into zulip:main Jan 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrisbobbe chrisbobbe Awaiting requested review from chrisbobbe

@gnprice gnprice Awaiting requested review from gnprice

Assignees

@gnprice gnprice

Labels

integration review Added by maintainers when PR may be ready for integration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@yash-agarwa-l @alya @chrisbobbe @gnprice