-
Notifications
You must be signed in to change notification settings - Fork 399
emoji: Use directional alignment for Unicode emoji on iOS #2069
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
e915e71 to
ab8f667
Compare
|
I'm not seeing a difference between the before and after screenshots in RTL; are those the intended screenshots? |
|
Yes, the changes made no visual difference. |
|
Hmm, interesting. Does this … Ah, no, there's also this: and the positioned child here doesn't specify its vertical alignment. So the horizontal axis of this |
The alignment argument has no effect on the horizontal axis, so replace centerLeft with center. Fixes the issue described here: zulip#2069 (comment)
ab8f667 to
400cc47
Compare
The alignment argument has no effect on the horizontal axis, so replace centerLeft with center. Fixes the issue described here: zulip#2069 (comment)
400cc47 to
20ee841
Compare
The alignment argument has no effect on the horizontal axis, so replace centerLeft with center. Fixes the issue described here: zulip#2069 (comment)
20ee841 to
5f2720f
Compare
|
Thanks! That’s right, I’ve updated it to use |
The alignment argument has no effect on the horizontal axis, so replace centerLeft with center. Fixes the issue described here: zulip#2069 (comment)
5f2720f to
9386ec5
Compare
The alignment argument has no effect on the horizontal axis, so replace centerLeft with center. Fixes the issue described here: zulip#2069 (comment)
9386ec5 to
5e8a4da
Compare
|
Thanks for the revision! Looks good; merging, once CI passes after this rebase. |
On iOS and macOS, use AlignmentDirectional.centerStart instead of Alignment.centerLeft for the Stack containing Unicode emoji.
This addresses a issue identified by @gnprice in this comment.
Before
LTR
RTL
After
LTR
RTL