compose: Focus topic input first when opening compose box #2072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sm-sayedi
force-pushed
the
1448-focus-topic-input
branch
from
57e9818 to
90afdb1
Compare
sm-sayedi
force-pushed
the
1448-focus-topic-input
branch
from
90afdb1 to
f06f048
Compare
sm-sayedi
force-pushed
the
1448-focus-topic-input
branch
from
f06f048 to
f03ce8b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1448
Before
In a channel feed, when there is no topic chosen yet, tapping the content input would choose "general chat" / "(no topic)" as the topic in the topic input and focus the content input. This would result in users accidentally sending messages to "general chat" / "(no topic)" while they were intending to send to a different topic.
Focus.topic.-.Before.mov
After
Now, when there is no topic chosen, tapping the content input would put focus on the topic input instead of the content input. This will hint to the user to choose the topic first, or skip the topic if they really want to.
Focus.Topic.-.After.mp4