Refactor content widgets toward touchable links #209
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making lists non-growable is a small optimization that's particularly helpful when creating a large number of short lists. That describes what we do here, mapping inline content nodes to corresponding inline spans: there will be tons of these nodes in a message list; tons of them will be in lists of one element (like any paragraph of plain text, or any link or strong/bold or emphasis/italic span with no further markup inside it); and probably the bulk of the rest will be in lists of two or three. So this is a spot where the optimization may well have a material performance impact. In any case it's essentially free; since we didn't want to add or remove elements anyway, the only cost is the extra few tokens in the source code.
This was basically the only appropriate way to use the return value of _buildInlineList, so it might as well get pushed inside the function itself.
chrisbobbe
force-pushed
the
pr-content-widgets
branch
from
55727dd to
a6dc643
Compare
|
Thanks! LGTM; merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is another segment of my draft branch #204, toward #71.
I think these refactors stand on their own, but in particular they will be helpful for (a) creating a stateful widget to hold gesture recognizers for links in a given BlockInlineContainerNode, and (b) threading those recognizers down through building the inline spans for that node's subtree.