Add DM action sheet, with "View profile" and "Mark conversation as read" buttons #2114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes zulip#1272. While working on the design update for the Inbox page, I noticed that we were well-prepared to implement the DM action sheet, including a way to show the participants of a group DM in the action sheet itself. For that, I've used a scrollable collection of user "chips" in the action-sheet header, with avatar, presence, and name. Discussion ongoing for whether we like this approach or prefer to put the users list on a separate page, as in issue zulip#1534: https://chat.zulip.org/#narrow/channel/48-mobile/topic/abbreviated.20headings/near/2366774 In this commit, the action sheet can have up to two buttons: - "View profile", for 1:1 DMs - "Mark conversation as read", if there are unreads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1272.
(This is a draft because there's an open discussion; see the "scrollable when long" screenshots and the CZO link there.)
The action sheet is offered in all four places mentioned in the issue:
Self-DM:
1:1 DM:
Group DM:
List of users in group DM, which is scrollable when long. We might still prefer a different page for this list (#1534); see #mobile > abbreviated headings @ 💬: