Add integration test of _UnreadMarker animation #349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@gnprice your comments on these commits in #317 (review) have been handled. |
gnprice
reviewed
Oct 31, 2023
docs/integration_tests.md
Outdated
| @@ -0,0 +1,62 @@ | |||
| # Integration Tests | |||
|
|
|||
| Integration tests in Flutter allow self-driven end-to-end | |||
There was a problem hiding this comment.
(continuing from #317 (comment) )
OK. Let's say "self-driving", then — that makes the car analogy more evident because that's the wording that's always used in that context, and that's also the wording they use in that package:integration_test readme.
integration_test/perf_driver.dart
Outdated
Comment on lines
8
to
11
| Future<void> main() { | ||
| return integrationDriver( |
There was a problem hiding this comment.
Suggested change
| Future<void> main() { | |
| return integrationDriver( | |
| Future<void> main() { | |
| // See cookbook recipe for this sort of driver: | |
| // https://docs.flutter.dev/cookbook/testing/integration/profiling#3-save-the-results-to-disk | |
| return integrationDriver( |
That way the relevant bit of docs is handy when editing this file in the future (cf #317 (comment) ).
sirpengi
force-pushed
the
pr-integration-tests
branch
from
382fc1e to
1708798
Compare
|
@gnprice this is ready! |
Added an initial integration test to capture render performance of _UnreadMarker animation. This method was helpful for comparing across different implementations of the marker to see if any method was more efficient than others. The test driver `integration_test/perf_driver.dart` is derived from BSD licensed example code in Flutter documentation about integration tests profiling, see: https://docs.flutter.dev/cookbook/testing/integration/profiling#3-save-the-results-to-disk Also added a `docs/integration_tests.md` to capture notes on the process of gathering performance metrics on physical devices.
gnprice
force-pushed
the
pr-integration-tests
branch
from
1708798 to
4efdc3a
Compare
|
Thanks for the revision! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was split off from #317 and is based on that branch. Also adds documentation on how to gather performance metrics on physical devices.