Skip to content

ui: Remove "Noto Color Emoji", broken on iOS (and maybe Android?) #403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 0 additions & 92 deletions assets/Noto_Color_Emoji/LICENSE

This file was deleted.

Binary file removed assets/Noto_Color_Emoji/Noto-COLRv1.ttf
Binary file not shown.
13 changes: 0 additions & 13 deletions lib/widgets/app.dart
Original file line number Diff line number Diff line change
Expand Up @@ -80,19 +80,6 @@ class ZulipApp extends StatelessWidget {
@override
Widget build(BuildContext context) {
final theme = ThemeData(
// This sets up the font fallback for normal text that
// may contain an emoji, where it will use any font from the "sans-serif"
// group to fetch the glyphs and fallback to "Noto Color Emoji" for emojis.
//
// Note that specifiying only "Noto Color Emoji" in the fallback list,
// Flutter tries to use it to draw even the non emoji characters
// which leads to broken text rendering.
fontFamilyFallback: [
// …since apparently iOS doesn't support 'sans-serif', use this instead:
// https://github.com/flutter/flutter/issues/63507#issuecomment-1698504425
if (Theme.of(context).platform == TargetPlatform.iOS) '.AppleSystemUIFont' else 'sans-serif',
'Noto Color Emoji',
],
// This applies Material 3's color system to produce a palette of
// appropriately matching and contrasting colors for use in a UI.
// The Zulip brand color is a starting point, but doesn't end up as
Expand Down
5 changes: 0 additions & 5 deletions pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ flutter:
assets:
- assets/Source_Code_Pro/LICENSE.md
- assets/Source_Sans_3/LICENSE.md
- assets/Noto_Color_Emoji/LICENSE

fonts:
# Zulip's custom icons. To use or edit, see class ZulipIcons.
Expand All @@ -129,8 +128,4 @@ flutter:
- asset: assets/Source_Sans_3/SourceSans3VF-Italic.otf
style: italic

- family: Noto Color Emoji
fonts:
- asset: assets/Noto_Color_Emoji/Noto-COLRv1.ttf

# If adding a font, remember to account for its license in lib/licenses.dart.