Set app's name and icon for the launcher #414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This devtools_options.yaml file seems to get created whenever I use the Flutter DevTools, the home of the Flutter inspector. It's pretty vacuous -- just one line reading "extensions:". Seems like it'd be better for it to not create it. But in the meantime we can make it not a problem for ourselves, by just telling Git to ignore it so it doesn't clutter things up.
This is a followup to 1c25b03, the second commit in this repo's history: in this round, we try to edit all the user-facing representations of the name of the app. Specifically it's "Zulip beta" for the two platforms where we currently plan to distribute to users in general (so that there's a risk of confusion if we just said "Zulip"), and just "Zulip" on the rest. We don't regularly test on all these platforms, so it's possible I broke something on, say, Windows. If so we'll presumably figure that out if and when we later try to run there.
Closed
This script is adapted lightly from the one with the same name in zulip-mobile. The SVGs that describe the design are also lightly adapted from what we have in zulip-mobile for debug builds. (Which say "DEBUG" rather than "BETA".) Fixes: zulip#390
gnprice
force-pushed
the
pr-launcher-icons
branch
from
75c5f7f to
d94c395
Compare
|
Cool, thanks! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #390.
The launch icons are lightly adapted from what we have in zulip-mobile for debug builds, along the lines described in #390: they're the Zulip logo like we use for the main app, plus a red banner reading "BETA".
This design isn't beautiful, and I'd love something better. (I'll file a follow-up issue for that. → #415) It hasn't really mattered for a debug-only thing that only us who are working on the app ever see, but will matter more for the beta. But this will be good enough for Beta 1, which the status quo wouldn't so much be.
The script that generates them is also lightly adapted from the
tools/generate-logosin zulip-mobile.We also edit the user-facing name of the app, in hopefully all the remaining places: it's now "Zulip beta" for Android and iOS (where we currently plan to distribute to users in general, so that there's a risk of confusion if we just said "Zulip"), and just "Zulip" on the miscellaneous other platforms.