notif: Add vm:entry-point pragma to _onBackgroundMessage
#529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes part of zulip#528, following the suggestion n-92 made here: zulip#342 (comment) Even with this change, notifications still don't yet work on Android in release builds. But after this change, when the app wasn't in the foreground, they get farther than before. Specifically they get just as far as they get, with or without this change, when the app was in the foreground. Details here: zulip#528 (comment)
|
Great, thanks! Merged, and looking forward to the rest of the fix for #528. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes part of #528, following the suggestion @n-92 made here:
#342 (comment)
Even with this change, notifications still don't yet work on Android in release builds. But after this change, when the app wasn't in the foreground, they get farther than before. Specifically they get just as far as they get, with or without this change, when the app was in the foreground. Details here:
#528 (comment)