Skip to content

content test: Skip source-file-reading test on Windows #700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 22, 2024

Conversation

gnprice
Copy link
Member

@gnprice gnprice commented May 22, 2024

This fails there, or at least does in the flutter/tests CI environment, with an error like:

::group::❌ C:/Users/RUNNER~1/AppData/Local/Temp/flutter_customer_testing.zulip.4a7c3de6/tests/test/model/content_test.dart: all content examples are tested (failed)
FileSystemException: Cannot open file, path = '/C:/Users/RUNNER~1/AppData/Local/Temp/flutter_customer_testing.zulip.4a7c3de6/tests/test/model/content_test.dart' (OS Error: The filename, directory name, or volume label syntax is incorrect.
, errno = 123)
dart:io                               _File.readAsStringSync
test\model\content_test.dart 1082:39  main.<fn>
::endgroup::

I'm not sure what's wrong, but don't really feel like finding out (or working out how to fix it) -- and, conveniently, there's really no need to do so. See comment.


This is needed for #239. See flutter/tests#368 and its CI result at https://github.com/flutter/tests/actions/runs/9197725826/job/25298839228?pr=368#step:3:9762 .

This fails there, or at least does in the `flutter/tests` CI
environment, with an error like:

    ::group::❌ C:/Users/RUNNER~1/AppData/Local/Temp/flutter_customer_testing.zulip.4a7c3de6/tests/test/model/content_test.dart: all content examples are tested (failed)
    FileSystemException: Cannot open file, path = '/C:/Users/RUNNER~1/AppData/Local/Temp/flutter_customer_testing.zulip.4a7c3de6/tests/test/model/content_test.dart' (OS Error: The filename, directory name, or volume label syntax is incorrect.
    , errno = 123)
    dart:io                               _File.readAsStringSync
    test\model\content_test.dart 1082:39  main.<fn>
    ::endgroup::

I'm not sure what's wrong, but don't really feel like finding out
(or working out how to fix it) -- and, conveniently, there's really
no need to do so.  See comment.
@gnprice gnprice requested a review from chrisbobbe May 22, 2024 21:18
@chrisbobbe chrisbobbe merged commit 9ea0584 into zulip:main May 22, 2024
1 check passed
@chrisbobbe
Copy link
Collaborator

Sure; merged.

@gnprice gnprice deleted the pr-fix-windows branch May 22, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants