Skip to content

deps: Upgrade flutter_local_notifications and Flutter to the latest #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

sm-sayedi
Copy link
Collaborator

@sm-sayedi sm-sayedi commented Jun 29, 2024

After the Flutter upstream commit: flutter/flutter@f23dbc5 a build error related to flutter_local_notifications plugin occurs when trying to run the app on Android. The upgrade to flutter_local_notifications 7.2.0 version in this PR resolves the issue.

More about the issue: MaikuB/flutter_local_notifications#2329

Fixes: #771

@sm-sayedi sm-sayedi added the integration review Added by maintainers when PR may be ready for integration label Jun 29, 2024
@sm-sayedi sm-sayedi requested a review from gnprice June 29, 2024 03:40
@sm-sayedi sm-sayedi changed the title deps: Upgrade flutter_local_notifications and Flutter to the latest deps: Upgrade flutter_local_notifications and Flutter to the latest Jul 1, 2024
@sm-sayedi sm-sayedi force-pushed the issue-771-android-build-fails branch from e710429 to e5c19c5 Compare July 1, 2024 14:45
sm-sayedi added 2 commits July 1, 2024 16:10
Also flutter_local_notifications_platform_interface.

After the Flutter upstream commit:
  flutter/flutter@f23dbc5
a build error related to flutter_local_notifications plugin occurs
when trying to run the app on Android. The upgrade to
flutter_local_notifications 17.2.1 resolves the issue.

More about the issue:
  MaikuB/flutter_local_notifications#2329

Fixes: zulip#771
@gnprice
Copy link
Member

gnprice commented Jul 1, 2024

Thanks! Looks good; merging.

I made a few adjustments to the commit message:

$ git range-diff pr/777...
1:  b7d430a6e ! 1:  2629ccb07 deps: Upgrade flutter_local_notifications to the latest
    @@ Metadata
     Author: Sayed Mahmood Sayedi <[email protected]>
     
      ## Commit message ##
    -    deps: Upgrade flutter_local_notifications to the latest
    +    deps: Upgrade flutter_local_notifications to latest, 17.2.1
     
    -    (The related flutter_local_notifications_platform_interface plugin is also
    -    upgraded to the latest.)
    +    Also flutter_local_notifications_platform_interface.
     
         After the Flutter upstream commit:
           https://github.com/flutter/flutter/commit/f23dbc50f05c56ef5be871203bb4f167f07df845
    -    a build error related to flutter_local_notifications plugin occurs when
    -    trying to run the app on Android. The upgrade to flutter_local_notifications ^7.2.0
    -    version resolves the issue.
    +    a build error related to flutter_local_notifications plugin occurs
    +    when trying to run the app on Android. The upgrade to
    +    flutter_local_notifications 17.2.1 resolves the issue.
     
         More about the issue:
           https://github.com/MaikuB/flutter_local_notifications/issues/2329
2:  e5c19c554 = 2:  2cbd7906b deps: Upgrade Flutter to 3.23.0-14.0.pre.77

The key bit that prompted me to make the edit is a factual point: the relevant flutter_local_notifications version is 17.2.1, not 7.2.0. (The other package's version is 7.2.0.)

Then a few smaller things I adjusted:

@gnprice gnprice force-pushed the issue-771-android-build-fails branch from e5c19c5 to 2cbd790 Compare July 1, 2024 23:18
@gnprice gnprice merged commit 2cbd790 into zulip:main Jul 1, 2024
1 check passed
@sm-sayedi
Copy link
Collaborator Author

sm-sayedi commented Jul 2, 2024

Thanks @gnprice and sorry for not noticing the wrong version number. And the caret-syntax link was really helpful. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when PR may be ready for integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android build fails on Flutter main, in flutter_local_notifications
2 participants